8000 [Feature] make modifications better for pyopenms by jpfeuffer · Pull Request #5584 · OpenMS/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature] make modifications better for pyopenms #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 15, 2021
Merged

[Feature] make modifications better for pyopenms #5584

merged 3 commits into from
Oct 15, 2021

Conversation

jpfeuffer
Copy link
Contributor

No description provided.

timosachsenberg
timosachsenberg approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor
@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Mainly questions.

@timosachsenberg
Copy link
Contributor

feel free to merge

@timosachsenberg
Copy link
Contributor

Feel free to merge. I think having so many different similar methods is not ideal but maybe requires a deeper look. Also some code seems a bit redundant.

@jpfeuffer
Copy link
Contributor Author

I see your point, although whenever you get a pointer from a function in OpenMS it will be from the database.
And whenever you have a non-pointer it is most likely not. In pyopenms only one is usable/visible.

Let's merge and tweak in a new PR. Feel free to open an issue.

@timosachsenberg
Copy link
Contributor

seems to be an upload error only

@timosachsenberg
Copy link
Contributor

rebuild jenkins

@jpfeuffer jpfeuffer merged commit cef7d2e into develop Oct 15, 2021
@jpfeuffer jpfeuffer deleted the feat/setModByMass branch October 15, 2021 09:05
@jpfeuffer jpfeuffer mentioned this pull request Oct 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hroest hroest hroest left review comments

@timosachsenberg timosachsenberg timosachsenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpfeuffer @timosachsenberg @hroest
0