8000 [Feature] Concatenate option for IDFileConverter by Waschi97 · Pull Request #4781 · OpenMS/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[Feature] Concatenate option for IDFileConverter #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 12, 2020
Merged

[Feature] Concatenate option for IDFileConverter #4781

merged 11 commits into from
Jun 12, 2020

Conversation

Waschi97
Copy link
Contributor
@Waschi97 Waschi97 commented Jun 9, 2020 •
edited
Loading

  • added a flag which allows the user to convert the top hits to one fasta entry

  • changed the way the fasta output is written

  • added TOPP tests for idXML to fasta conversion

This feature is needed for the database suitability metric.

@ghost
Copy link
ghost commented Jun 9, 2020 •
edited by ghost
Loading

Congratulations 🎉. DeepCode analyzed your code in 2.213 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
cbielow
cbielow reviewed Jun 9, 2020
View reviewed changes
@Waschi97 Waschi97 marked this pull request as ready for review June 11, 2020 12:03
cbielow
cbielow reviewed Jun 11, 2020
View reviewed changes
@jpfeuffer jpfeuffer merged commit 061e695 into OpenMS:develop Jun 12, 2020
@Waschi97 Waschi97 deleted the feature/ConcatPepsInIDFileConverter branch June 15, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbielow cbielow cbielow left review comments

@jpfeuffer jpfeuffer jpfeuffer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3784
3 participants
@Waschi97 @cbielow @jpfeuffer
0