[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/merging functions with type capturing #328

Merged
merged 10 commits into from
Feb 2, 2024

Conversation

nielstron
Copy link
Contributor

Discovers and fixes a few bugs in the type system for tricky re-assignments and local definitions

This happens because the name of captured variables is the same but the
type is not. The type is merge after the branch but not checked to be
compatible with the function type.

A simple fix should disallow merging the functions because they capture
variables of different types.
This is a particularly nasty bug because it does not surface until
running the code. It may cause strictly less validation than expected
but never more (i.e. funds may get locked but not be stolen)
@nielstron nielstron merged commit 7de70fb into dev Feb 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant