8000 fixed responsiveness issue in chapters page by M-ayank2005 · Pull Request #1453 · OWASP/Nest · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fixed responsiveness issue in chapters page #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fixed responsiveness issue in chapters page #1453

wants to merge 4 commits into from

Conversation

M-ayank2005
Copy link
Contributor

Resolves #1382

Description

Fixes the "View Details" button alignment on the Projects page for mobile view (360x744), ensuring consistency with the Chapters page. Adjusted the Card component layout using Tailwind CSS for proper alignment and responsiveness.

Key Changes

  • Centered button on mobile, aligned to the right on desktop.
  • Added responsive Tailwind classes for consistent styling.
  • Used tailwind classes to differentiate screen sizes.

Testing

Verified alignment on various screen sizes and ensured consistency across pages.

@M-ayank2005 M-ayank2005 requested review from arkid15r and kasya as code owners May 1, 2025 21:01
@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 1, 2025 •
edited
Loading

Summary by CodeRabbit

  • Style

    • Unified and simplified padding, margin, and layout for card elements to ensure consistent appearance.
    • Enhanced link styling with improved color transitions and hover effects.

  • Refactor

    • Removed responsive state logic and hooks, streamlining the component for a cleaner structure.
    • Simplified layout and conditional rendering for social links, contributors, and action buttons for better clarity and maintainability.
      """

Summary by CodeRabbit

  • Refactor
    • Simplified the card layout by removing dynamic mobile responsiveness and unifying styling for consistent appearance across devices.
    • Improved spacing, alignment, and visual consistency for project details, badges, links, and action buttons.
    • Enhanced accessibility and interactivity of project links with updated styling and hover effects.

Walkthrough

This change refactors the Card component in the frontend by removing state and effect hooks related to window resizing and mobile view detection. The layout and styling are restructured to use unified padding, clearer markup, and more consistent class usage. Conditional rendering logic based on mobile state is eliminated, and the component now relies on responsive CSS classes for layout adjustments. The structure of the card's bottom section is simplified, with social links, contributors, and the action button reorganized for consistent alignment and spacing across screen sizes.

Changes

File(s) Change Summary
frontend/src/components/Card.tsx Removed window resize state/effect hooks, unified padding, simplified conditional rendering, restructured layout for consistent styling, removed utility function usage, clarified markup with comments, and adjusted class names for responsiveness.

Assessment against linked issues

Objective Addressed Explanation
Consistent alignment and padding of "View Details" button on Projects page in mobile view (#1382) ✅

Possibly related PRs

Suggested reviewers

  • kasya
  • arkid15r
    """

Tip

⚡️ Faster reviews with caching
  • CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 544b8a7 and e7a1724.

📒 Files selected for processing (1)
  • frontend/src/components/Card.tsx (5 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/components/Card.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arkid15r arkid15r requested a review from aramattamara May 2, 2025 00:13
arkid15r
arkid15r requested changes May 4, 2025
View reviewed changes
Copy link
Collaborator
@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run make check before submitting your PRs.

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@M-ayank2005
Copy link
Contributor Author

@arkid15r ,I have committed the changes after running the tests and performing a make check. Please review them at your convenience. Thank you!

image

@M-ayank2005 M-ayank2005 requested a review from arkid15r May 8, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasya kasya Awaiting requested review from kasya kasya is a code owner

@aramattamara aramattamara Awaiting requested review from aramattamara

@arkid15r arkid15r Awaiting requested review from arkid15r arkid15r is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Inconsistent "View Details" Button Alignment on Projects Page (Mobile View)
2 participants
@M-ayank2005 @arkid15r
0