8000 Add option to disable Passenger telemetry · Issue #4347 · OSC/ondemand · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add option to disable Passenger telemetry #4347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vibe-Guy opened this issue May 8, 2025 · 3 comments
Open

Add option to disable Passenger telemetry #4347

Vibe-Guy opened this issue May 8, 2025 · 3 comments

Comments

@Vibe-Guy
Copy link
Contributor
Vibe-Guy commented May 8, 2025

Hey
While debugging an issue during the Passenger startup I noticed that the Passenger telemetry is enabled by default and haven't found any option in OnDemand to disable it. I believe the user should have an option for that.

Probably the best way would be to add the "passenger_disable_anonymous_telemetry on;" variable to the nginx pun config of the user at /var/lib/ondemand-nginx/config/.conf.
This would probably mean adding a variable to the defaults which is then parsed inside the template for the user PUNs. The variable could also be used by the Ansible role.

I'm happy to try to provide the required changes as pull request if you are interested in this improvement.

@osc-bot osc-bot added this to the Backlog milestone May 8, 2025
@johrstrom
Copy link
Contributor

Yea it seems like it should be disabled by default. Happy to look at a PR for the same.

That said - I think you can probably disable this through passenger_options here:

https://osc.github.io/ood-documentation/latest/reference/files/nginx-stage-yml.html

Vibe-Guy added a commit to Vibe-Guy/ondemand that referenced this issue May 9, 2025
Vibe-Guy added a commit to Vibe-Guy/ood-ansible that referenced this issue May 9, 2025
@Vibe-Guy
Copy link
Contributor Author
Vibe-Guy commented May 9, 2025

Thanks. I would prefer to add a separate variable to make it clear this option exists (rather than requiring the user to know what option to specify).

What is the correct release path here? I deployed the changes to the PUN template to my installation, but now nginx_stage is complaining about the unknown option ('Warning: invalid configuration option "passenger_disable_anonymous_telemetry"') and skips it when I want to generate a new PUN config.
I presume the new option needs to be added to nginx_stage by merging the changes to the ondemand repo here before it makes sense adding them to the ood-ansible role?

@johrstrom
Copy link
Contributor

Yea it has to be supported here upstream before we can support it in the automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
0