8000 [18.0][MIG] product_variant_name: Migration to 18.0 by BhaveshHeliconia · Pull Request #388 · OCA/product-variant · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[18.0][MIG] product_variant_name: Migration to 18.0 #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] product_variant_name: Migration to 18.0 #388

wants to merge 7 commits into from

Conversation

BhaveshHeliconia
Copy link
Contributor

No description provided.

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from fcf81fb to 59b49d5 Compare January 24, 2025 07:40
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from 59b49d5 to d067f49 Compare February 6, 2025 11:27
JordiMForgeFlow and others added 6 commits March 31, 2025 15:06
@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from d067f49 to 3749b49 Compare March 31, 2025 09:36
marcelsavegnago
marcelsavegnago approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member
@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rrebollo
rrebollo approved these changes Jun 25, 2025
View reviewed changes
Copy link
@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a suggestion for your consideration—feel free to address it as you see fit.

product_variant_name/tests/test_product_variant_name.py Outdated
from odoo.tests import TransactionCase


class TestProductVariantName(TransactionCase):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could use BaseCommon instead of TransactionCase

@BhaveshHeliconia BhaveshHeliconia force-pushed the 18.0-mig-product_variant_name branch from 3749b49 to 3da48a4 Compare June 26, 2025 05:35
@BhaveshHeliconia
Copy link
Contributor Author

@rrebollo : It's done. Thank you for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@rrebollo rrebollo rrebollo approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BhaveshHeliconia @marcelsavegnago @rrebollo @OCA-git-bot @JordiMForgeFlow @mymage @Ivorra78
0