[FIX] inherited form does not have Lots #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👎 reject Hello @kingofsevens If I'm not wrong, the variant modules will need some ground rework in v8/master after OpenERP SA improved the variant management in the core but without considering very well OCA developments unfortunately. I need to talk in more details with the latest projects maintainers such as @sebastienbeau but I think we will just move the module to an 'unported' folder on master or v8 to explicit the module were not ported yet and then later we would rework them for V8/master. Therefore I current reject your merge proposal, I hope you understand. If you want to contribute, then the steps are the ones I mentioned I believe. What do you think. |
|
Well, no offense taken. We have recently used these modules in a project. I wanted to do a quick fix. This is essential if someone wants to use this in v7, but I totally agree to a move to 'unported' folder since most of the work is done by v8 in the core. |
|
wait a minute, your fix is for v7? If so please do the merge proposal against the 7.0 branch (you proposed it against "master"). Could you confirm? |
|
Oops my bad. Yes it is against 7.0 branch.. I shall create another pull request then.. |
|
that's why then. Thanks. |
JavierIniesta
pushed a commit
to Antiun/product-variant
that referenced
this pull request
Nov 26, 2015
sergio-teruel
pushed a commit
to sergio-teruel/product-variant
that referenced
this pull request
Apr 15, 2016
…variant [IMP][8.0] product_variant_supplierinfo: More test coverage
pedrobaeza
pushed a commit
that referenced
this pull request
Dec 6, 2016
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
chienandalu
pushed a commit
to Tecnativa/product-variant
that referenced
this pull request
Jul 4, 2017
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
chienandalu
pushed a commit
to Tecnativa/product-variant
that referenced
this pull request
Jul 11, 2017
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
pedrobaeza
pushed a commit
to Tecnativa/product-variant
that referenced
this pull request
Sep 21, 2017
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
simoneversienti
pushed a commit
to simoneversienti/product-variant
that referenced
this pull request
Jan 22, 2018
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
angelmoya
pushed a commit
to PESOL/product-variant
that referenced
this pull request
Aug 15, 2018
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
pedrobaeza
pushed a commit
to PESOL/product-variant
that referenced
this pull request
Oct 24, 2018
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
AdriaGForgeFlow
referenced
this pull request
in ForgeFlow/product-variant
Jun 20, 2019
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
p-tombez
pushed a commit
to p-tombez/product-variant
that referenced
this pull request
Dec 18, 2019
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
HviorForgeFlow
referenced
this pull request
in ForgeFlow/product-variant
Jun 25, 2020
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
AdriaGForgeFlow
referenced
this pull request
in ForgeFlow/product-variant
Jun 25, 2020
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
HviorForgeFlow
referenced
this pull request
in ForgeFlow/product-variant
Sep 14, 2020
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
HviorForgeFlow
referenced
this pull request
in ForgeFlow/product-variant
Jul 7, 2022
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
JasminSForgeFlow
referenced
this pull request
in ForgeFlow/product-variant
Jul 14, 2022
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
OCA-git-bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
SergioPSV
pushed a commit
to SergioPSV/product-variant
that referenced
this pull request
Mar 3, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
SergioPSV
pushed a commit
to SergioPSV/product-variant
that referenced
this pull request
Mar 3, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
SergioPSV
pushed a commit
to SergioPSV/product-variant
that referenced
this pull request
Mar 3, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
Ricardoalso
pushed a commit
to camptocamp/product-variant
that referenced
this pull request
Sep 1, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
Ricardoalso
pushed a commit
to camptocamp/product-variant
that referenced
this pull request
Sep 1, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
Ricardoalso
pushed a commit
to camptocamp/product-variant
that referenced
this pull request
Sep 1, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
Ricardoalso
pushed a commit
to camptocamp/product-variant
that referenced
this pull request
Sep 1, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
Ricardoalso
pushed a commit
to camptocamp/product-variant
that referenced
this pull request
Sep 7, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
OCA-git-bot
pushed a commit
that referenced
this pull request
Oct 2, 2023
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
BT-dmoreno
pushed a commit
to BT-dmoreno/product-variant
that referenced
this pull request
Apr 24, 2024
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
MarioLM-23
pushed a commit
to MarioLM-23/product-variant
that referenced
this pull request
May 8, 2024
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
manuelregidor
pushed a commit
to sygel-technology/product-variant
that referenced
this pull request
Jun 6, 2024
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
67ED
yibudak
referenced
this pull request
in altinkaya-opensource/product-variant
Oct 23, 2024
Add Translation
BhaveshHeliconia
pushed a commit
to HeliconiaIO/product-variant
that referenced
this pull request
Jan 17, 2025
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
BhaveshHeliconia
pushed a commit
to HeliconiaIO/product-variant
that referenced
this pull request
Mar 31, 2025
What helps is setting the many2many_tags which seems to have an influence even though the field is invisible. Without this you sometimes get a warning asking if you want to discard the last change. Setting the computed field readonly is also good practice. [IMP] new api style in onchange for updating attributes list [IMP] better to avoid overrides of onchange method (OCA#2) [REF] refactoring of the onchanges This should be easier to understand and cover all cases of changing product template and product in any order, so you always get a consistent list of attributes. [FIX] fix tests in purchase_product_variant_configurator [FIX] avoid systematic warning when creating new product templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running gives XML error.. this fixes and places the page item..