Rename try_advisory_lock to advisory_lock_or_retry #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed in #139 /cc @lmignon @pedrobaeza @damdam-s |
|
You should change tests accordingly the rename: 2015-11-03 07:42:01,583 22882 ERROR openerp_test openerp.addons.connector.tests.test_connector: File "/home/travis/build/OCA/connector/connector/tests/test_connector.py", line 229, in test_concurrent_import_lock
2015-11-03 07:42:01,583 22882 ERROR openerp_test openerp.addons.connector.tests.test_connector: with connector_unit.try_advisory_lock(lock):
2015-11-03 07:42:01,583 22882 ERROR openerp_test openerp.addons.connector.tests.test_connector: ` AttributeError: 'ConnectorUnit' object has no attribute 'try_advisory_lock' |
a267288 to
7745e8b
Compare
This is what happen when I code before being totally awake, and you caught it even before I could realize :-D |
It is no longer a context manager, because we would expect the lock to be released at the end of the 'with' statement but it lasts until the end of the transaction.
<
10000
a class="d-inline-block" data-test-selector="pr-timeline-events-actor-avatar" data-hovercard-type="user" data-hovercard-url="/users/guewen/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="/guewen">
guewen
force-pushed
the
advisory-lock-common
branch
from
November 3, 2015 07:52
7745e8b to
15e0e45
Compare
|
👍 Thank you for the changes. |
|
Thanks 👍 |
|
👍 |
lmignon
added a commit
that referenced
this pull request
Nov 3, 2015
Rename try_advisory_lock to advisory_lock_or_retry
guewen
added a commit
to guewen/connector-magento
that referenced
this pull request
Nov 3, 2015
It uses the new OCA/connector#138, OCA/connector#139 feature.
guewen
added a commit
to guewen/connector-magento
that referenced
this pull request
Nov 3, 2015
It uses the new OCA/connector#138, OCA/connector#139 feature.
atchuthan
pushed a commit
to sodexis/connector-magento
that referenced
this pull request
May 19, 2016
It uses the new OCA/connector#138, OCA/connector#139 feature.
atchuthan
pushed a commit
to sodexis/connector-magento
that referenced
this pull request
Oct 18, 2016
It uses the new OCA/connector#138, OCA/connector#139 feature.
guewen
added a commit
to guewen/connector-magento
that referenced
this pull request
Jun 20, 2017
It uses the new OCA/connector#138, OCA/connector#139 feature.
IJOL
pushed a commit
to BITVAX/connector-magento
that referenced
this pull request
Sep 10, 2018
It uses the new OCA/connector#138, OCA/connector#139 feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer a context manager, because we would expect the lock to be
released at the end of the 'with' statement but it lasts until the end of the
transaction.