Rust check features and packages parameters #81
Conversation
a69b16a to
919911a
Compare
There was a problem hiding this comment.
I wonder if instead of fixing this here, we should fix this in poe test-rs.
If we had something like:
test-bozu-default = "cargo test --all-features"
test-bozu-funny-
test-bozu-funny-two = "cargo test --package funny_two --feature two"
test-rs = ["test-bozu-default", "test-bozu-funny-one", "test-bozy-funny-two"]
(apologies I can't be bothered to look up the details of the funnyness)
Then poe test-rs would run the three different test commands and we'd also have poe test-bozu-default etc. commands available locally if we wanted them.
|
Ah I see my suggestion would work well for test but would have to replicated for clippy. Is it nicer to centralise that here? I'm not sure I still like the idea of being able to run the commands that CI would run locally more easily. Which my suggestion achieves. |
919911a to
acbb81f
Compare
Definitely a fan of having an easy way of running the same tests both locally and in CI, though my approach to this in the past has been to use the local github workflows runner act. Either way, I think it'd make sense to have parity between |
acbb81f to
b64098c
Compare
|
I've not used |
|
|
Adds
FEATURESandPACKAGESinputs to therust-checkworkflow to support the oddities ofbozu, also removes theFMT_TOOLCHAINinput which was unused (making it a breaking change). Not too happy about duplicating theGenerate Flagsstep, but moving it into it's own job felt even worse