10000 feat: Implement Reusable Responsive Table for Inspector & Owner Dashboards by ussyalfaks · Pull Request #353 · NoshonNetworks/landver · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Implement Reusable Responsive Table for Inspector & Owner Dashboards #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 13, 2025
Merged

feat: Implement Reusable Responsive Table for Inspector & Owner Dashboards #353

merged 2 commits into from
Apr 13, 2025

Conversation

ussyalfaks
Copy link
Contributor

Detailed Information

This PR introduces a reusable table component that functions seamlessly across both the Inspector and Owner dashboards. It is designed to be pixel perfect and fully responsive, ensuring consistency with the provided design specifications.

🎯 Features & Requirements

✅ Built as a reusable component to support multiple dashboard views

🎨 Matches the exact pixel measurements and design from the provided mockups

📱 Fully responsive, working smoothly across devices and screen sizes

🔁 Integrates cleanly into both the Inspector and Owner dashboard layouts

⚙️ Configurable for different datasets and table structures

🛠 Technical Notes

Compatible with existing project styling and architecture

Follows established UI patterns and component structure

Designed for maintainability and reusability

✅ Definition of Done

 Table component created and reusable across views

 Integrated with both Inspector and Owner dashboards

 UI verified for pixel perfection against designs

 Responsiveness tested across common breakpoints

 Code aligned with project conventions and standards

Related Issues

Closes #343

Type of Change

  • 🐛 Bug fix or ⚙️ enhancement
  • ✨ New feature or Chore (change with no new features or fixes)
  • 📚 Documentation update

Checklist (select as many as applicable)

  • The code follows the style guidelines of this project.
  • All new and existing tests pass.
  • This pull request is ready to be merged and reviewed.

Solomonsolomonsolomon
Solomonsolomonsolomon reviewed Apr 13, 2025
View reviewed changes
Copy link
Contributor
@Solomonsolomonsolomon Solomonsolomonsolomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful PR!!, all tables should be using the reusable table component

app/client/app/dashboard/owner/components/bestSeller.tsx
<ViewAllButton />
</div>

<div className="overflow-x-auto">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not reusable

@Solomonsolomonsolomon
Copy link
Contributor

LGTM!

@Solomonsolomonsolomon Solomonsolomonsolomon merged commit a27b353 into NoshonNetworks:develop Apr 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Solomonsolomonsolomon Solomonsolomonsolomon Solomonsolomonsolomon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Reusable Responsive Table for Inspector & Owner Dashboards
2 participants
@ussyalfaks @Solomonsolomonsolomon
0