8000 kubectl-rook-ceph: init at 0.9.3 by vinylen · Pull Request #398797 · NixOS/nixpkgs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

kubectl-rook-ceph: init at 0.9.3 #398797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2025
Merged

kubectl-rook-ceph: init at 0.9.3 #398797

merged 1 commit into from
Apr 19, 2025

Conversation

vinylen
Copy link
Member
@vinylen vinylen commented Apr 15, 2025

Add krew plugin kubectl-rook-ceph at version 0.9.3

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 15, 2025
acid-bong
acid-bong suggested changes Apr 15, 2025
View reviewed changes
@vinylen
Copy link
Member Author
vinylen commented Apr 15, 2025

@acid-bong Thanks for the review. I've updated the PR with changes related to your comments :)

awwpotato
awwpotato suggested changes Apr 15, 2025
View reviewed changes
awwpotato
awwpotato reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor
@awwpotato awwpotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also all your commits should be squashed into one

8000
@vinylen vinylen force-pushed the init_kubectl_rook_ceph branch from 1b13608 to b0f83eb Compare April 16, 2025 05:04
@vinylen vinylen requested a review from awwpotato April 16, 2025 05:05
awwpotato
awwpotato approved these changes Apr 16, 2025
View reviewed changes
@vinylen vinylen force-pushed the init_kubectl_rook_ceph branch from b0f83eb to a245842 Compare April 16, 2025 20:21
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2343

Aleksanaa
Aleksanaa reviewed Apr 17, 2025
View reviewed changes
@vinylen vinylen force-pushed the init_kubectl_rook_ceph branch from a245842 to b7e9eb8 Compare April 17, 2025 05:18
@Aleksanaa
Copy link
Member

@ofborg build kubectl-rook-ceph

@SuperSandro2000 SuperSandro2000 merged commit c5c1a2a into NixOS:master Apr 19, 2025
31 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aleksanaa Aleksanaa Aleksanaa left review comments

@acid-bong acid-bong acid-bong approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@awwpotato awwpotato awwpotato approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vinylen @nixos-discourse @Aleksanaa @SuperSandro2000 @acid-bong @awwpotato
0