feat: core flags management for Samba 3+ #890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically set core_module and account_provider flags on Samba instances. Since version 3, Samba can be installed from Software Center as a normal application to implement AD member role.
The "available" list key is "id", not "name" used as the human-readable module name.
Since Samba application instances can be both with/without core_module flag, check the actual flag state for each app instance instead checking only the first one. To ensure destination checks are performed on every Samba instance (no matter its role), filter out core_module instances _after_ the destination check is done.
The Samba app cannot be restored if the node hosts another Samba instance. See also #862 Refs NethServer/dev#7384
andre8244
approved these changes
May 29, 2025
No changes needed on the UI side! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Samba 3 app version is like a standard app: it has no
core_moduleflag. When it is installed from Domain and Users page dynamically set the traditional module flagscore_moduleandaccount_provider.Furthermore, fix the existing library and actions behavior to consistently list Samba in both Software Center and Core Apps views, depending on the actual instance flags.
Refs NethServer/dev#7384