metadata management manually #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
suro-pull-requests #141 SUCCESS |
| @@ -211,7 +211,7 @@ project(':suro-s3') { | |||
| compile project(':suro-localfile') | |||
|
|
|||
| compile 'net.java.dev.jets3t:jets3t:0.9.2' | |||
| compile 'com.amazonaws:aws-java-sdk:1.4.7' | |||
| compile 'com.amazonaws:aws-java-sdk-s3:1.9.3' | |||
There was a problem hiding this comment.
not sure if this is gonna to be an issue. platform/atlas pulls in the uber jar of aws-java-sdk.
There was a problem hiding this comment.
I changed this because atlas plugin was pulling separate sdk.Platform is pulling uber jar but suro-localfile is not included in the platform, so I can control its dependencies on the suro-server side.
| metadataFetchedTopicSet.add(message.getRoutingKey()); | ||
| } | ||
| sendMessage(message); | ||
| metadataWaitingQueuePolicy.release(); |
There was a problem hiding this comment.
I think release() needs to be called at the beginning of the run(). Because when run() is executed, this task is already dequeued from executor's queue, which should allow another task to enqueue immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.