8000 It may be not suitable to use `/` as separator in DynamicRemotePrefixFormatter · Issue #131 · Netflix/suro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

It may be not suitable to use / as separator in DynamicRemotePrefixFormatter #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhenchuan opened this issue Sep 22, 2014 · 1 comment
Closed

It may be not suitable to use / as separator in DynamicRemotePrefixFormatter #131

zhenchuan opened this issue Sep 22, 2014 · 1 comment

Comments

@zhenchuan
Copy link

if i want to upload file to hdfs with dynamic directory with format yyyy/MM/dd/HH , how can i achieve that ?

    @JsonCreator
    public DynamicRemotePrefixFormatter(@JsonProperty("format") String formatString) {
        String[] formatList = formatString.split("/");
        for (String format : formatList) {
            formatterList.add(createFormatter(format));
        }
    }

suro/suro-s3/src/main/java/com/netflix/suro/sink/remotefile/formatter/DynamicRemotePrefixFormatter.java

Line 18 in 586917e

String[] formatList = formatString.split("/");

@metacret
Copy link
Contributor

We need to change format string delimiter, or format string delimiter can be parameterized. This is simple fix and you can feel free to send PR.

iPinYou added a commit to iPinYou/suro that referenced this issue Sep 23, 2014
@iPinYou
Netflix#131 semicolon will be a better choice.
4188595
@iPinYou iPinYou mentioned this issue Sep 23, 2014
Merged
metacret added a commit that referenced this issue Sep 23, 2014
@metacret
Merge pull request #134 from iPinYou/ISSUES-131
00d18fd 
#131 semicolon will be a better choice for seperate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metacret @zhenchuan
0