8000 Add thread support by sgedward · Pull Request #65 · Netflix/hubcommander · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add thread support #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 29, 2017
Merged

Add thread support #65

merged 3 commits into from
Oct 29, 2017

Conversation

sgedward
Copy link
Contributor
@sgedward sgedward commented Oct 22, 2017 •
edited
Loading

#55

Change:
slack_comm.py

@mikegrima
Copy link
Contributor

Hello @sgedward. Would prefer not making use of globals.

I think this would be best accomplished by having a function to return a timestamp, and having thread sent in via a keyword arg to the say* functions.

I think an approach similar to #63 would best implement this feature.

@sgedward
Copy link
Contributor Author

@mikegrima thanks for leting me know. fixed

@mikegrima
Copy link
Contributor

Testing this today

@mikegrima
Copy link
Contributor

@sgedward slight merge conflict that should be very easy to fix.

@mikegrima
Copy link
Contributor

I'll fix the conflict -- some changes I need to make to incorporate this PR with the ephemeral messages one.

@mikegrima mikegrima merged commit 6095d00 into Netflix:develop Oct 29, 2017
@mikegrima mikegrima mentioned this pull request Oct 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgedward @mikegrima
0