8000 fix for update task during retry workflow by apanicker-nflx · Pull Request #949 · Netflix/conductor · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

fix for update task during retry workflow #949

Merged
merged 1 commit into from
Jan 17, 2019
Merged

fix for update task during retry workflow #949

merged 1 commit into from
Jan 17, 2019

Conversation

apanicker-nflx
Copy link
Collaborator

No description provided.

@apanicker-nflx apanicker-nflx requested review from a user and kishorebanala January 17, 2019 21:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2283

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 67.571%
Totals Coverage Status
Change from base Build 2273: -0.002%
Covered Lines: 8820
Relevant Lines: 13053
💛 - Coveralls

@codecov
Copy link
codecov bot commented Jan 17, 2019 •
edited
Loading

Codecov Report

Merging #949 into dev will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #949      +/-   ##
============================================
- Coverage     62.03%   61.99%   -0.05%     
+ Complexity     2628     2627       -1     
============================================
  Files           239      239              
  Lines         13054    13053       -1     
  Branches       1291     1291              
============================================
- Hits           8098     8092       -6     
- Misses         4232     4237       +5     
  Partials        724      724
Impacted Files Coverage Δ Complexity Δ
...lix/conductor/core/execution/WorkflowExecutor.java 71.42% <100%> (-0.05%) 115 <0> (ø)
.../java/com/netflix/conductor/service/Lifecycle.java 30% <0%> (-30%) 2% <0%> (-1%)
.../com/netflix/conductor/grpc/server/GRPCServer.java 78.57% <0%> (-14.29%) 4% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a15de...cca9912. Read the comment docs.

@apanicker-nflx apanicker-nflx merged commit d33758e into dev Jan 17, 2019
@apanicker-nflx apanicker-nflx deleted the bugfix/retry_workflow_update_task branch January 17, 2019 21:15
long-64 pushed a commit to long-64/conductor that referenced this pull request Oct 2, 2019
@apanicker-nflx
Merge pull request Netflix#949 from Netflix/bugfix/retry_workflow_upd…
64bccda 
…ate_task

fix for update task during retry workflow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kishorebanala kishorebanala Awaiting requested review from kishorebanala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apanicker-nflx @coveralls
0