Upgrade to EstNLTK 1.7.4; simplify license section in README #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #831 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 95 95
Lines 7182 7182
=======================================
Hits 7156 7156
Misses 26 26 ☔ View full report in Codecov by Sentry. |
juhoinkinen
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the optional EstNLTK dependency from version 1.7.3 to 1.7.4.
The functionality relevant for Annif is unaffected, but the new EstNLTK release is now dual-licensed (GPLv2 + Apache 2.0), which simplifies the legal situation. Thus, the License section in the top level README can be shortened, as it doesn't have to consider GPLv2 compatibility.