Ensure compatibility with MLLM models trained using Annif 1.2 or older #834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 96 96
Lines 7217 7220 +3
=======================================
+ Hits 7191 7194 +3
Misses 26 26 ☔ View full report in Codecov by Sentry. |
juhoinkinen
approved these changes
Feb 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check to ensure that MLLM TokenSet objects use frozenset to store tokens. In models prior to Annif 1.3, the tokens were stored in a mutable set. The
__setstate__method is called during unpickling and handles the conversion so that older models will still work.We could drop this later on if compatibility with older models is no longer relevant, for example if there is another reason that they will stop working anyway.