Footers for tenants #201
Footers for tenants #201
Conversation
|
Preview deployment: https://footer.preview.avy-fx.org |
| </div> | ||
| </div> | ||
| <div className="container text-center pb-8"> | ||
| <p className="mb-2">All Content © 2017 – 2025 {name}</p> |
There was a problem hiding this comment.
How did we come up with these dates, and who owns the copyright? Do we want the end date to be dynamic from new Date() so we don't need to update it?
There was a problem hiding this comment.
These were in the mocks which appears to be taken from the current website. And it's common to use a span to show the years of publication. I typically just use new Date() to show the current year, but this might be a Rusty question.
There was a problem hiding this comment.
Gotcha - yeah, let's check to see if we can be dynamic, that would be nice to have.
There was a problem hiding this comment.
It would be nice to include this in a settings collection I think. Could default to just current year if there isn't a start year set. I don't know how we would refer to that. Content copyright starting year?
| return { | ||
| tenant: tenant.id, | ||
| footerLogo: brandImages[tenant.slug]['logo'].id, | ||
| name: tenant.name, |
There was a problem hiding this comment.
Would we ever want the footer's name to be something other than the tenant's name? If not, we should imo remove the field and just look up the tenant's name for rendering.
There was a problem hiding this comment.
I am not sure - which is why I made this dynamic. I will ask Rusty and report back.
There was a problem hiding this comment.
It looks like we can just import the tenants name. I will update this
Description
Creates a customizable footer for each tenant. This PR does not include the subscribe form (Issue created #200)
Issue
Resolves #102
Screenshot