8000 Simplify options in sdr_upgrades_tmy3.yml, follow-up by joseph-robertson · Pull Request #1428 · NREL/resstock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Simplify options in sdr_upgrades_tmy3.yml, follow-up #1428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

Simplify options in sdr_upgrades_tmy3.yml, follow-up #1428

wants to merge 23 commits into from
+245 −184

Conversation

joseph-robertson
Copy link
Contributor
@joseph-robertson joseph-robertson commented Jun 4, 2025 •
edited
Loading

Pull Request Description

Improve/clarify names for options:

  • "ASHP, SEER 16, 9.2 HSPF, Integrated Backup, 5F-40F switchover band" to "Dual-Fuel ASHP, SEER 16, 9.2 HSPF, Existing Integrated Backup, 5F-40F switchover band"
  • "ASHP, SEER 16, 9.2 HSPF, Separate Backup" to "ASHP, SEER 16, 9.2 HSPF, Existing Separate Backup"
  • "MSHP, SEER 16, 9.2 HSPF, Separate Backup, Max Load" to "MSHP, SEER 16, 9.2 HSPF, Existing Separate Backup, Max Load"

For these options, set:

  • heat_pump_backup_fuel=auto
  • heat_pump_backup_heating_efficiency=auto

Move heat_pump_backup_use_existing_system argument assignment from parameter Heat Pump Backup to HVAC Heating Efficiency. For each of the above options, set it to true. Delete the Heat Pump Backup parameter row from the lookup.

A Required argument 'heat_pump_backup_fuel' not provided for measure 'BuildResidentialHPXML'. error will now be thrown when trying to use, e.g., the "Dual-Fuel ASHP, SEER 16, 9.2 HSPF, Existing Integrated Backup, 5F-40F switchover band" option without heat_pump_backup_use_existing_system=true.

Related Pull Requests

#1074

Related Issues

[What issue(s) is the PR addressing]

Checklist

Required:

Optional (not all items may apply):

@joseph-robertson joseph-robertson added this to the ResStock v3.5.0 milestone Jun 4, 2025
@joseph-robertson joseph-robertson self-assigned this Jun 4, 2025
@joseph-robertson joseph-robertson marked this pull request as ready for review June 5, 2025 13:40
@joseph-robertson joseph-robertson requested a review from shorowit June 5, 2025 13:48
@joseph-robertson
Copy link
Contributor Author

Include more argument description for heat_pump_backup_use_existing_system around backup fuel/efficiency being overwritten.

@joseph-robertson joseph-robertson requested review from afontani and removed request for shorowit June 9, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontani afontani Awaiting requested review from afontani

At least 1 approving review is required to merge this pull request.

Assignees

@joseph-robertson joseph-robertson

Labels
bug
Projects
None yet
Milestone
ResStock v3.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@joseph-robertson
0