8000 2.2.0-beta release by mdeceglie · Pull Request #344 · NREL/rdtools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

2.2.0-beta release #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 14, 2022
Merged

2.2.0-beta release #344

merged 4 commits into from
Sep 14, 2022

Conversation

mdeceglie
Copy link
Collaborator
@mdeceglie mdeceglie commented Sep 13, 2022 •
edited
Loading
  • Code changes are covered by tests
  • Code changes have been evaluated for compatibility/integration with TrendAnalysis
  • New functions added to __init__.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • Updated changelog

@kandersolar
Copy link
Member

Is it time to clean up/summarize the dependency updates as mentioned in #326 (comment)?

#339 is also ready for review and could go in this release if we want.

@mdeceglie
Copy link
Collaborator Author

Good point on the dependency updates. I'm toying with the idea of just capturing the details of changes to setup.py, for others perhaps we could just point to the relevant PRs and note that there are changes but not worry about every specific package. Another heuristic would be to only report the details of changes to direct dependencies. What do you think @kanderso-nrel?

@kandersolar
Copy link
Member

Copying over all the sundry requirements.txt changes to the changelog does seem unnecessary; fine with me to say "we changed some things" and link the PRs. I do like the idea of continuing to list the changes to setup.py though.

@mdeceglie
Copy link
Collaborator Author

Regarding #326, that might go to master as a patch, so I suggest not holding up this PR

@mdeceglie mdeceglie changed the title add version tag to change log 2.2.0-beta release Sep 13, 2022
@mdeceglie
Copy link
Collaborator Author

i think I got the change log clean up correct...

@mdeceglie
Copy link
Collaborator Author

Should degradation_timeseries_plot() be added to __init__.py?

@kandersolar
Copy link
Member

Should degradation_timeseries_plot() be added to init.py?

The function isn't in an experimental module, but maybe the function itself is sort of unofficially experimental? I think I'd lean towards adding it to __init__.py, but I could go either way.

Otherwise I think this LGTM.

@mdeceglie
Copy link
Collaborator Author
mdeceglie commented Sep 13, 2022 •
edited
Loading

I agree. The things we left out of __init__.py would produce a warning on rdtools import, and we didn't feel that this new function needed a warning, so I think it's ok to include, especially since this is for a beta release.

@mdeceglie mdeceglie merged commit 0de0d14 into development Sep 14, 2022
@kandersolar kandersolar deleted the 2.2.0-beta_release branch September 19, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdeline cdeline Awaiting requested review from cdeline

@kandersolar kandersolar Awaiting requested review from kandersolar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdeceglie @kandersolar
0