8000 Remove deprecated postprocessing methods by asparke2 · Pull Request #343 · NREL/ComStock · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove deprecated postprocessing methods #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Remove deprecated postprocessing methods #343

merged 2 commits into from
May 14, 2025

Conversation

asparke2
Copy link
Member
@asparke2 asparke2 commented May 6, 2025 •
edited by mdahlhausen
Loading

Pull request overview

Removes postprocessing methods have been replaced with the more general export_metadata_and_annual_results. These methods should have been removed in #275 but were not due to oversight on my part.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/reporting_measure_tests.txt, test/workflow_measure_tests.txt, or test/upgrade_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@asparke2
Remove deprecated postprocessing methods
16f68cd 
These methods have been replaced with the more general export_metadata_and_annual_results
@asparke2
Copy link
Member Author
asparke2 commented May 6, 2025

@mdahlhausen can you remove comstock.create_national_aggregation() from the compare_comstock_to_cbecs_issue87.py file and re-run to confirm this works?

@mdahlhausen
Copy link
Contributor

getting a different overflow error

@asparke2
Fix reload_from_csv
982b011 
Fix reload_from_csv to read cached parquet files if available. Using scan_parquet with hive partitioning for LazyFrame optimization.
@mdahlhausen mdahlhausen merged commit 48f93e8 into main May 14, 2025
@mdahlhausen mdahlhausen deleted the asparke2/deprecated_postproc_methods branch May 14, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdahlhausen mdahlhausen mdahlhausen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asparke2 @mdahlhausen
0