[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module-config respip missing in unbound.conf.5.in man page #492

Closed
he32 opened this issue May 21, 2021 · 5 comments · Fixed by #494
Closed

module-config respip missing in unbound.conf.5.in man page #492

he32 opened this issue May 21, 2021 · 5 comments · Fixed by #494

Comments

@he32
Copy link
Contributor
he32 commented May 21, 2021

Describe the bug
The documentation of the "respip" module-config is missing in the unbound.conf(5) man page source.
I'm wondering what other parts of the documentation for the RPZ feature is missing...

To reproduce
Steps to reproduce the behavior:

  1. Inspect documentation, see it missing.

Expected behavior
The documentation for a supported feature should not be omitted.

System:

  • Unbound version: 1.13.1
  • OS: NetBSD
  • unbound -V output:
Version 1.13.1

Configure line: --enable-allsymbols --with-libexpat=/usr --with-libevent=/usr --enable-event-api --with-ssl=/usr --with-pidfile=/var/run/unbound/unbound.pid --sysconfdir=/usr/pkg/etc --with-libnghttp2 --enable-gost --enable-sha2 --prefix=/usr/pkg --build=x86_64--netbsd --host=x86_64--netbsd --mandir=/usr/pkg/man --enable-option-checking=yes
Linked libs: pluggable-libevent 2.1.8-stable (it uses kqueue), OpenSSL 1.1.1k  25 Mar 2021
Linked modules: dns64 respip validator iterator

BSD licensed, see LICENSE in source package for details.
Report bugs to unbound-bugs@nlnetlabs.nl or https://github.com/NLnetLabs/unbound/issues

Additional information
A sweep should probably be made to add any other missing documentation bits related to the RPZ feature.
@wcawijngaards
Copy link
Member

The documentation for the respip module is contributed and is it is in the doc folder, here is the location in the code repository
https://github.com/NLnetLabs/unbound/blob/master/doc/IP-BasedActions.pdf

That said, a note in the man page could be useful too.

@he32
Copy link
Contributor Author
he32 commented May 25, 2021

Hm, OK, thanks for the pointer -- that's useful.

However, that looks a little "half-integrated".
I guess you won't object to me drafting a pull request to integrate this in the man page properly?

@he32
Copy link
Contributor Author
he32 commented May 25, 2021

To this end, see pull request #494.

@wcawijngaards wcawijngaards linked a pull request May 25, 2021 that will close this issue
Transplant parts of the contributed RPZ documentation. #494
Merged
wcawijngaards added a commit that referenced this issue May 25, 2021
@wcawijngaards
- Fix #492: module-config respip missing in unbound.conf.5.in man
58eeeeb 
  page. Merges #494 from he32.
Remove comment line (?) from man page.
@wcawijngaards
Copy link
Member

Yes of course, thank you. That looks nice for the documentation in the man page!

Merged it into the code repository. Removed the comment line in minimal-responses.

@he32
Copy link
Contributor Author
he32 commented May 25, 2021

Right, the comment was just to balance the single-apostrophe in the previous line, and fix the font highlighting in my emacs... :)

wcawijngaards added a commit that referenced this issue May 25, 2021
@wcawijngaards
- For #492: Fix font highlighting for the man page on emacs.
0f2ae81
jedisct1 added a commit to jedisct1/unbound that referenced this issue May 31, 2021
@jedisct1
Merge remote-tracking branch 'nlnet/master'
0ed7748 
* nlnet/master:
  - zonemd-check: yesno option, default no, enables the processing   of ZONEMD records for that zone.
  - Merge NLnetLabs#496 from banburybill: Use build system endianness if   available, otherwise try to work it out.
  Use build system endianness if available, otherwise try to work it out.
  - For NLnetLabs#492: Fix font highlighting for the man page on emacs.
  - Fix NLnetLabs#492: module-config respip missing in unbound.conf.5.in man   page. Merges NLnetLabs#494 from he32. Remove comment line (?) from man page.
  Transplant parts of the contributed RPZ documentation.
  - Move the NSEC3 max iterations count in line with the 150 value   used by BIND, Knot and PowerDNS. This sets the default value   for it in the configuration to 150 for all key sizes.
  - Test code has -q option for quiet output.
  - Fix for NLnetLabs#411, NLnetLabs#439, NLnetLabs#469: Reset the DNS message ID when moving queries   between TCP streams. - Refactor for uniform way to produce random DNS message IDs.
  Fix date in changelog.
  - Fix NLnetLabs#489: Compile using MSYS2 MinGW 64-bit.
  - Fix that auth-zone zonefiles use last TTL if no TTL is specified.
  Changelog note for NLnetLabs#487 - Merge PR NLnetLabs#487: ifdef RLIMIT_AS in recently added check.
  ifdef RLIMIT_AS in recently added check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transplant parts of the contributed RPZ documentation. he32/unbound
2 participants
@he32 @wcawijngaards