10000 Refactor ci-release.yml by anissa111 · Pull Request #628 · NCAR/geocat-comp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor ci-release.yml #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Refactor ci-release.yml #628

merged 3 commits into from
Jun 21, 2024

Conversation

anissa111
Copy link
Member

PR Summary

Nothing was wrong with the windows release, thankfully, it was a problem stemming from trying the pip install in the same environment that the conda version had been uninstalled from.

Changes:

  • splits conda and pypi releases into two separate jobs
  • adds pre-install environment cacheing

See action run on my fork

Related Tickets & Documents

Closes #627

PR Checklist

General

  • PR includes a summary of changes
  • Link relevant issues, make one if none exist
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the upcoming release.
  • Add appropriate labels to this PR
  • PR follows the Contributor's Guide

@anissa111 anissa111 added bug Something isn't working refactor Internal code refactoring testing Issue related to testing labels Jun 12, 2024
Copy link
Contributor
@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anissa111 anissa111 merged commit 04accb2 into NCAR:main Jun 21, 2024
12 checks passed
@anissa111 anissa111 deleted the fix-release-test branch June 21, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Internal code refactoring testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows pypi release test failing
2 participants
0