8000 Add a note about potential type promotion to interp_multidim by kafitzgerald · Pull Request #504 · NCAR/geocat-comp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add a note about potential type promotion to interp_multidim #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 23, 2023

Conversation

kafitzgerald
Copy link
Contributor
@kafitzgerald kafitzgerald commented Nov 2, 2023

PR Summary

Add a note about potential type promotion to interp_multidim docs and fix a few typos.

Closes #488

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst in a relevant section for the next unreleased release. Possible sections include: Documentation, New Features, Bug Fixes, Internal Changes, Breaking Changes/Deprecated
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.
  • If needed, squash and merge PR commits into a single commit to clean up commit history

@kafitzgerald kafitzgerald added the documentation Improvements or additions to documentation label Nov 2, 2023
@kafitzgerald kafitzgerald marked this pull request as draft November 21, 2023 23:09
@kafitzgerald kafitzgerald self-assigned this Nov 21, 2023
@kafitzgerald kafitzgerald marked this pull request as ready for review November 22, 2023 00:26
Copy link
Member
@anissa111 anissa111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@kafitzgerald kafitzgerald merged commit 816b78a into NCAR:main Nov 23, 2023
@kafitzgerald kafitzgerald deleted the issue488 branch November 23, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

interp_multidim can change data precision
2 participants
0