-
Notifications
You must be signed in to change notification settings - Fork 55
Fix Python version in upstream CI #436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://github.com/NCAR/geocat-comp/actions/runs/5490783568 It's no longer failing due to missing dependencies after this change, however it's still generally failing due to other reasons (the ones you mentioned that were unrelated to this issue) |
35674a8
to
b8dd984
Compare
See manually triggered upstream actions run here: https://github.com/NCAR/geocat-comp/actions/runs/6660041805 |
Yeah, hopefully this helps that situation, but it certainly won't get things passing (upstream CI was failing before the issue this addresses because of #381). Maybe this makes things more clear though w/ the other failures. I'm by no committed to get this merged on its own - just was trying to remove one layer from the problem or show how to (since we got that far once). I'll leave that call to you @anissa111. Let me know if you'd like me to look into / help with this more @cyschneck / @anissa111 otherwise I was planning to just leave this here for now. And looks like we are back to the failure from #381 (so it's working as intended). |
Ah, let's just get it merged, one less thing to deal with later! |
PR Summary
Remove Python from upstream dev CI environment file so it does unintentionally update to the latest version and break things.
Closes #435
PR Checklist
General
closes #XXX
to the PR description where XXX is the number of the issue.docs/release-notes.rst
@NCAR/geocat
for reviewsprecommit
. To set up on your local, runpre-commit install
from the top level of the repository. To manually run pre-commits, usepre-commit run --all-files
and re-add any changed files before committing again and pushing.