8000 Fix Python version in upstream CI by philipc2 · Pull Request #436 · NCAR/geocat-comp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Python version in upstream CI #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Fix Python version in upstream CI #436

merged 2 commits into from
Oct 26, 2023

Conversation

philipc2
Copy link
Member
@philipc2 philipc2 commented Jul 7, 2023

PR Summary

Remove Python from upstream dev CI environment file so it does unintentionally update to the latest version and break things.
Closes #435

PR Checklist

General

  • Make an issue if one doesn't already exist
  • Link the issue this PR resolves by adding closes #XXX to the PR description where XXX is the number of the issue.
  • Add a brief summary of changes to docs/release-notes.rst
  • Add appropriate labels to this PR
  • Make your changes in a forked repository rather than directly in this repo
  • Open this PR as a draft if it is not ready for review
  • Convert this PR from a draft to a full PR before requesting reviewers
  • Request @NCAR/geocat for reviews
  • Passes precommit. To set up on your local, run pre-commit install from the top level of the repository. To manually run pre-commits, use pre-commit run --all-files and re-add any changed files before committing again and pushing.

@philipc2 philipc2 linked an issue Jul 7, 2023 that may be closed by this pull request
@philipc2
Copy link
Member Author
philipc2 commented Jul 7, 2023

@kafitzgerald

https://github.com/NCAR/geocat-comp/actions/runs/5490783568

It's no longer failing due to missing dependencies after this change, however it's still generally failing due to other reasons (the ones you mentioned that were unrelated to this issue)

@kafitzgerald kafitzgerald force-pushed the philipc2/fix-upstream branch from 35674a8 to b8dd984 Compare October 26, 2023 21:17
@kafitzgerald kafitzgerald added bug Something isn't working developer feature For development standardization / best practices / enhancement testing Issue related to testing labels Oct 26, 2023
@kafitzgerald kafitzgerald marked this pull request as ready for review October 26, 2023 21:35
@kafitzgerald kafitzgerald changed the title DRAFT: Fix Upstream CI Fix Python version in upstream CI Oct 26, 2023
@anissa111
Copy link
Member

See manually triggered upstream actions run here: https://github.com/NCAR/geocat-comp/actions/runs/6660041805

@kafitzgerald
Copy link
Contributor
kafitzgerald commented Oct 26, 2023

See manually triggered upstream actions run here: https://github.com/NCAR/geocat-comp/actions/runs/6660041805

Yeah, hopefully this helps that situation, but it certainly won't get things passing (upstream CI was failing before the issue this addresses because of #381). Maybe this makes things more clear though w/ the other failures.

I'm by no committed to get this merged on its own - just was trying to remove one layer from the problem or show how to (since we got that far once). I'll leave that call to you @anissa111.

Let me know if you'd like me to look into / help with this more @cyschneck / @anissa111 otherwise I was planning to just leave this here for now.

And looks like we are back to the failure from #381 (so it's working as intended).

@anissa111
Copy link
Member

See manually triggered upstream actions run here: NCAR/geocat-comp/actions/runs/6660041805

Yeah, hopefully this helps that situation, but it certainly won't get things passing (upstream CI was failing before the issue this addresses because of #381). Maybe this makes things more clear though w/ the other failures.

I'm by no committed to get this merged on its own - just was trying to remove one layer from the problem or show how to (since we got that far once). I'll leave that call to you @anissa111.

Let me know if you'd like me to look into / help with this more @cyschneck / @anissa111 otherwise I was planning to just leave this here for now.

And looks like we are back to the failure from #381 (so it's working as intended).

Ah, let's just get it merged, one less thing to deal with later!

@anissa111 anissa111 merged commit 1a9135a into main Oct 26, 2023
@anissa111 anissa111 deleted the philipc2/fix-upstream branch October 26, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working developer feature For development standardization / best practices / enhancement testing Issue related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream-dev CI failing after 3.11 update
3 participants
0