New mod install #83
Merged
New mod install #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0952eb9 to
3bdd20c
Compare
3bdd20c to
5f47691
Compare
a-camargo
reviewed
Dec 26, 2023
launcher/commands/check.py
Outdated
| @@ -3,8 +3,9 @@ | |||
| from os.path import sep | |||
| from typing import Iterator, Tuple | |||
|
|
|||
| from launcher.commands.common import read_mod_maker, parse_moddb_data | |||
| from launcher.commands.common import read_mod_maker | |||
There was a problem hiding this comment.
from launcher.mods import read_mod_maker
a-camargo
reviewed
Dec 26, 2023
launcher/commands/tests.py
Outdated
| @@ -2,8 +2,9 @@ | |||
| from typing import Dict | |||
|
|
|||
| from launcher.archive import list_archive_content | |||
| from launcher.commands.common import read_mod_maker, parse_moddb_data | |||
| from launcher.commands.common import read_mod_maker | |||
There was a problem hiding this comment.
from launcher.mods import read_mod_maker
Only pass the Path to modpack_data directory
5adfeaf to
c82eee6
Compare
match only title instead of author / title
Don't have time yet to redo it + not really used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #68