8000 [UPUP-1077]: PageRequestService by ridebyhorse · Pull Request #5 · MobileUpLLC/PagingList · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[UPUP-1077]: PageRequestService #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[UPUP-1077]: PageRequestService #5

wants to merge 19 commits into from

Conversation

ridebyhorse
Copy link
@ridebyhorse ridebyhorse commented Apr 18, 2025 •
edited
Loading

maria.nesterova added 15 commits April 16, 2025 12:30
@ridebyhorse ridebyhorse requested a review from d-sushkov April 18, 2025 14:55
@ridebyhorse ridebyhorse self-assigned this Apr 18, 2025
NatalyaLuzyanina
NatalyaLuzyanina reviewed Apr 21, 2025
View reviewed changes
Example/Sources/Repository/IntsRepository.swift
@@ -20,11 +20,12 @@ extension IntsRepositoryError: LocalizedError {
}
}

class IntsRepository {
final class IntsRepository: Sendable {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зачем тут Sendable? Вроде бы не нужен

Copy link
Author
@ridebyhorse ridebyhorse Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Получаем такую ошибку при обращении к репозиторию:
Снимок экрана 2025-04-22 в 17 11 49
Sendable решает проблему

NatalyaLuzyanina
NatalyaLuzyanina reviewed Apr 21, 2025
View reviewed changes
Example/Sources/Repository/IntsRepository.swift Outdated
private enum Constants {
static let delayInNanoseconds: UInt64 = 3_000_000_000
}

@Sendable
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

и тут тоже

Copy link
Author
@ridebyhorse ridebyhorse Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут хоть и нет ворнинга на Swift 6, для Swift 5 нужно добавить
Снимок экрана 2025-04-23 в 11 27 55

NatalyaLuzyanina
NatalyaLuzyanina reviewed Apr 21, 2025
View reviewed changes
yanboyko
yanboyko requested changes Apr 21, 2025
View reviewed changes
@yanboyko
Copy link

Еще пара моментов:

  1. Проект не билдится из-за ворнингов, нужно исправить все замечания от линтера.
  2. Получилось сломать пагинацию, на скрине видно как после 10 элемента идет 31. Особо ничего не делал, но вроде последовательность такая: отмотал до пагинационной загрузки, пока она шла сделал пул ту рефреш и снова отмотал до пагинационной загрузки.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NatalyaLuzyanina NatalyaLuzyanina NatalyaLuzyanina left review comments

@yanboyko yanboyko yanboyko requested changes

@koshkar koshkar koshkar approved these changes

@d-sushkov d-sushkov Awaiting requested review from d-sushkov

Assignees

@ridebyhorse ridebyhorse

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ridebyhorse @yanboyko @NatalyaLuzyanina @koshkar
0