refactor: improve upload script #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the uploading script to enhance logging, centralize the main procedure, and improve robustness through dynamic retry delays.
- Introduces a reusable log() function to standardize logging output.
- Moves the procedural code into a main() function and refines retry logic with dynamic delay.
- Adjusts error handling by incorporating sys.exit and updates variable naming for clarity.
Comments suppressed due to low confidence (2)
python/upload.py:45
- Consider using a context manager (with statement) to open the file in order to ensure that the file handle is properly closed after the upload completes.
files={"file": open(file, "rb")},
python/upload.py:74
- [nitpick] The variable name 'file' shadows a Python built-in. Consider renaming it (e.g., to 'file_path') to avoid potential confusion.
_, rid, version, os, arch, channel, token, file = sys.argv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does improvements to the uploading script.
Key changes:
refactor: fucking logging Introduce a reusable function for
printrefactor: move main procedure Move all the procedures to a main function
chore: codestyle and typo Correct "retires" to "retries"
feat: robust improvement Use
sys.exitand morefeat: optimize retry delay Add dynamic retry delay