-
Notifications
You must be signed in to change notification settings - Fork 967
Fix mistakes in .openpublishing.redirection.json
#5451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mistakes in .openpublishing.redirection.json
#5451
Conversation
Learn Build status updates of commit 237718a: ✅ Validation status: passed
For more details, please refer to the build report. |
PRMerger Results
|
@@ -13752,12 +13752,12 @@ | |||
}, | |||
{ | |||
"source_path": "docs/c-runtime-library/operator-delete-crt.md", | |||
"redirect_url": "docs/c-runtime-library/delete-operator-crt", | |||
"redirect_url": "/cpp/c-runtime-library/delete-operator-crt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old redirect_url
redirects https://learn.microsoft.com/cpp/c-runtime-library/operator-delete-crt
to https://learn.microsoft.com/en-us/cpp/c-runtime-library/docs/c-runtime-library/delete-operator-crt
, leading to a 404.
"redirect_document_id": false | ||
}, | ||
{ | ||
"source_path": "docs/c-runtime-library/operator-new-crt.md", | ||
"redirect_url": "docs/c-runtime-library/new-operator-crt", | ||
"redirect_url": "/cpp/c-runtime-library/new-operator-crt", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old redirect_url
redirects https://learn.microsoft.com/cpp/c-runtime-library/operator-new-crt
to https://learn.microsoft.com/en-us/cpp/c-runtime-library/docs/c-runtime-library/new-operator-crt
, leading to a 404.
@@ -21,7 +21,7 @@ | |||
"redirect_document_id": true | |||
}, | |||
{ | |||
"source_path": "docs/supported-platforms-visual-cpp.md.md", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra .md
causes the redirection to not work (same for the other occurrence).
@TylerMSFT - Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appreciate those fixes. Good eye!
#sign-off |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @ |
Hi @v-dirichards, I believe this PR can be merged. Just wanted to flag it out as Tyler's sign off didn't go through. |
@Rageking8 Thank you! Will merge shortly! |
d714fad
into
MicrosoftDocs:main
Fix:
.md
extension insource_path
redirect_url