8000 Fix mistakes in `.openpublishing.redirection.json` by Rageking8 · Pull Request #5451 · MicrosoftDocs/cpp-docs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix mistakes in .openpublishing.redirection.json #5451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Rageking8
Copy link
Contributor

Fix:

  • Duplicated .md extension in source_path
  • Wrong redirect_url

Copy link
8000
Contributor

Learn Build status updates of commit 237718a:

✅ Validation status: passed

File Status Preview URL Details
.openpublishing.redirection.json ✅Succeeded

For more details, please refer to the build report.

Copy link
Contributor

PRMerger Results

Issue Description
Json File This PR contains json file(s).

@@ -13752,12 +13752,12 @@
},
{
"source_path": "docs/c-runtime-library/operator-delete-crt.md",
"redirect_url": "docs/c-runtime-library/delete-operator-crt",
"redirect_url": "/cpp/c-runtime-library/delete-operator-crt",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old redirect_url redirects https://learn.microsoft.com/cpp/c-runtime-library/operator-delete-crt to https://learn.microsoft.com/en-us/cpp/c-runtime-library/docs/c-runtime-library/delete-operator-crt, leading to a 404.

"redirect_document_id": false
},
{
"source_path": "docs/c-runtime-library/operator-new-crt.md",
"redirect_url": "docs/c-runtime-library/new-operator-crt",
"redirect_url": "/cpp/c-runtime-library/new-operator-crt",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old redirect_url redirects https://learn.microsoft.com/cpp/c-runtime-library/operator-new-crt to https://learn.microsoft.com/en-us/cpp/c-runtime-library/docs/c-runtime-library/new-operator-crt, leading to a 404.

@@ -21,7 +21,7 @@
"redirect_document_id": true
},
{
"source_path": "docs/supported-platforms-visual-cpp.md.md",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra .md causes the redirection to not work (same for the other occurrence).

@v-regandowner
Copy link
Contributor

@TylerMSFT - Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged Tracking label for the PR review team label Jun 23, 2025
Copy link
Collaborator
@TylerMSFT TylerMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate those fixes. Good eye!

@TylerMSFT
Copy link
Collaborator

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @

@Rageking8
Copy link
Contributor Author

Hi @v-dirichards, I believe this PR can be merged. Just wanted to flag it out as Tyler's sign off didn't go through.

@v-dirichards
Copy link
Contributor

Hi @v-dirichards, I believe this PR can be merged. Just wanted to flag it out as Tyler's sign off didn't go through.

@Rageking8 Thank you! Will merge shortly!

@v-dirichards v-dirichards merged commit d714fad into MicrosoftDocs:main Jun 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0