chore(runway): cherry-pick fix: cp-7.50.0 fix infinite loader and inconsistent completedOnboarding value
#16726
+143
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onsistent `completedOnboarding` value (#16695) ## **Description** This PR removes the backfill for `completedOnboarding` that was located in `app/store/index.ts` and introduces a new `useCompletedOnboardingEffect` that observes `KeyringControllerState.vault` and the current value of `completedOnboarding` in order to automatically set `completedOnboarding`. This ensures that `completedOnboarding` is rightfully set, even when the user kills the app right before completing onboarding, or during the reset wallet flow. ## **Related issues** Fixes: #16638 Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-152 ## **Manual testing steps** 1. Onboard as a new user 2. Reset your wallet 3. Kill the app 4. Reload the app 5. Verify that there's no infinite loader 6. Onboard as a new user BUT kill the app just before clicking "Done" (the last onboarding step) 7. Reload the app and login 8. Verify that `completedOnboarding` is true, either by verifying the state logs, or by verifying that account syncing was dispatched ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
|
|
tommasini
approved these changes
Jun 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completedOnboardingvalue (fix: cp-7.50.0 fix infinite loader and inconsistentcompletedOnboardingvalue #16695)Description
This PR removes the backfill for
completedOnboardingthat was locatedin
app/store/index.tsand introduces a newuseCompletedOnboardingEffectthat observesKeyringControllerState.vaultand the current value ofcompletedOnboardingin order to automatically setcompletedOnboarding.This ensures that
completedOnboardingis rightfully set, even when theuser kills the app right before completing onboarding, or during the
reset wallet flow.
Related issues
Fixes: #16638
Related to: https://consensyssoftware.atlassian.net/browse/IDENTITY-152
Manual testing steps
(the last onboarding step)
completedOnboardingis true, either by verifying thestate logs, or by verifying that account syncing was dispatched
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. ca0d327