8000 Make private ip the same as geoip:private by hamjin · Pull Request #1061 · MetaCubeX/mihomo · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make private ip the same as geoip:private #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: Alpha
Choose a base branch
from
Open

Make private ip the same as geoip:private #1061

wants to merge 4 commits into from

Conversation

hamjin
Copy link
@hamjin hamjin commented Feb 25, 2024

Currently ip.IsPrivate and netip.Addr.IsPrivate only matches a part of private IPs. This pr uses the CIDR list from geoip:private to fix it.

@hamjin
Make private ip the same as geoip:private
088fdb2 
Currently ip.IsPrivate and netip.Addr.IsPrivate only matches a part of private IPs.
@Skyxim
Copy link
Collaborator
Skyxim commented Feb 25, 2024 •
edited
Loading

https://datatracker.ietf.org/doc/html/rfc1918#section-3

These IPs are not clearly defined

@hamjin
Copy link
Author
hamjin commented Feb 25, 2024 •
edited
Loading

https://datatracker.ietf.org/doc/html/rfc1918#section-3

These are private IPs in https://github.com/MetaCubeX/meta-rules-dat/blob/meta/geo/geoip/private.list
Some network (eg in office) resolves websites to 100.64.0.0/16, which won't be matched by ip.IsPrivate

8000
@wwqgtxx wwqgtxx force-pushed the Alpha branch 4 times, most recently from 6321cfb to 092e535 Compare February 27, 2024 07:21
@ForestL18
Copy link

其实geoip:private里面的地址不应该叫做Private IP Addresses，而应该是Reserved IP addresses。
个人认为排除所有的Reserved IP addresses相对来说应该更好一些。

@daiaji
Copy link
daiaji commented Mar 1, 2024

其实geoip:private里面的地址不应该叫做Private IP Addresses，而应该是Reserved IP addresses。 个人认为排除所有的Reserved IP addresses相对来说应该更好一些。

确实在理

@hamjin
Copy link
Author
hamjin commented Mar 1, 2024 •
edited
Loading

Reserved IP addresses

这看上去更应该修改geoip-code让它支持多个code，或者增加单独的filter以接受指定IP段的结果

@xishang0128 xishang0128 force-pushed the Alpha branch 5 times, most recently from 99b6ffa to 44d8a14 Compare March 11, 2024 19:14
@xishang0128 xishang0128 force-pushed the Alpha branch 4 times, most recently from af42ed0 to 3b472f7 Compare April 1, 2024 10:16
@xishang0128 xishang0128 force-pushed the Alpha branch 2 times, most recently from c3fdcff to ae45564 Compare April 7, 2024 12:57
@wwqgtxx wwqgtxx force-pushed the Alpha branch 5 times, most recently from 65fea35 to ecbbf9d Compare September 11, 2024 02:56
@xishang0128 xishang0128 force-pushed the Alpha branch 2 times, most recently from 22addc6 to 5772507 Compare October 10, 2024 23:36
@wwqgtxx wwqgtxx force-pushed the Alpha branch 5 times, most recently from 08c68ed to 68abb13 Compare March 17, 2025 03:10
@wwqgtxx wwqgtxx force-pushed the Alpha branch 4 times, most recently from a6afffb to 3d2cb99 Compare April 15, 2025 19:14
@wwqgtxx wwqgtxx force-pushed the Alpha branch 4 times, most recently from 590bcc7 to 99aa1b0 Compare April 22, 2025 13:17
@wwqgtxx wwqgtxx force-pushed the Alpha branch 5 times, most recently from fe15d49 to 86c127d Compare May 4, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamjin @Skyxim @ForestL18 @daiaji
0