Replace pixel size of fonts with point sizes #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is how it looks like now: Thoughts:
|
|
@wonder-sk thanks for such tests! I have applied the scale |
|
Great, thanks for the updates! Now it looks roughly the same as it used to in terms of fonts and element sizing... To be checked on other devices... On my phone: |
|
One more thing that caught my eye is that the record button's "donut" icon has very small hole in the donut now :-) |
PeterPetrik
approved these changes
Dec 14, 2021
|
@wonder-sk tested it on two additional devices, it seems to be small on them (I can now see 5 icons in the main toolbar on map, previously there were only 4). We need to find a way to scale it appropriately based on device's resolution
|
|
From my tests, feature form editor labels are bigger now, however previously I think they were too small on Android |
wonder-sk
reviewed
Dec 15, 2021
NEDJIMAbelgacem
pushed a commit
that referenced
this pull request
Dec 22, 2021
With high DPI scaling enabled, on some devices, the devicePixelRatio() is a bit off from the real ratio that we used to calculate ourselves (= DPI / 160) where 160 dpi is considered the "standard" dpi on Android. While on many phones/tablets this difference would be small (e.g. 0-3%), on some devices this discrepancy was larger according to our previous calculations (e.g. Huawei P30 has devicePixelRatio() = 3 while with 422 DPI it is ~2.6375 which means ~14% difference). The discrepancy means that the whole GUI was suddenly larger than it used to be, wasting space. So we keep using __dp to adjust scaling for these cases - under normal circumstances __dp should be 1 or somewhere near one - in the example of Huawei P30 __dp is ~0.8774 ( = 2.6375 / 3) In addition, record button has been replaced by SVG and few other minor GUI updates. Fixes #1833
tomasMizera
added a commit
that referenced
this pull request
Jan 11, 2022
Initial implementation of long range stake-out navigation between user position and a point feature. All commits: * initial implementation * add docs * try fix * navigation UI fixes * fix recenter icon * fix map click behaviour * address reviews * refactoring * fix memory leak * update qtquick libs versions * add navigation highlight * fix * remove unnecessary change * small typo * fix gps position update * fix #1824 crash on 32b start * Translate /app/i18n/input_en.ts in nl translation completed for the source file '/app/i18n/input_en.ts' on the 'nl' language. * add shared libraries after unwind as per docs * Translate /app/i18n/input_en.ts in es at least 75% translated for the source file '/app/i18n/input_en.ts' on the 'es' language. Manual sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format * Translate /app/i18n/input_en.ts in es translation completed for the source file '/app/i18n/input_en.ts' on the 'es' language. * Translate /app/i18n/input_en.ts in ca translated for the source file '/app/i18n/input_en.ts' on the 'ca' language. * Translate /app/i18n/input_en.ts in hr_HR translation completed for the source file '/app/i18n/input_en.ts' on the 'hr_HR' language. * Fix large GUI elements on some devices (#1848) With high DPI scaling enabled, on some devices, the devicePixelRatio() is a bit off from the real ratio that we used to calculate ourselves (= DPI / 160) where 160 dpi is considered the "standard" dpi on Android. While on many phones/tablets this difference would be small (e.g. 0-3%), on some devices this discrepancy was larger according to our previous calculations (e.g. Huawei P30 has devicePixelRatio() = 3 while with 422 DPI it is ~2.6375 which means ~14% difference). The discrepancy means that the whole GUI was suddenly larger than it used to be, wasting space. So we keep using __dp to adjust scaling for these cases - under normal circumstances __dp should be 1 or somewhere near one - in the example of Huawei P30 __dp is ~0.8774 ( = 2.6375 / 3) In addition, record button has been replaced by SVG and few other minor GUI updates. Fixes #1833 * update strings * release translations * Translate /app/i18n/input_en.ts in fi translation completed for the source file '/app/i18n/input_en.ts' on the 'fi' language. * Translate /app/i18n/input_en.ts in he translation completed for the source file '/app/i18n/input_en.ts' on the 'he' language. * Translate /app/i18n/input_en.ts in ca translation completed for the source file '/app/i18n/input_en.ts' on the 'ca' language. * set up concurrency between workflow runs * test CI cancellation * fix copypaste error * change test file in copy-to-qgis script * update app version to 1.2.1 * fix versions update script for Android fix release * Translate /app/i18n/input_en.ts in ja_JP translation completed for the source file '/app/i18n/input_en.ts' on the 'ja_JP' language. * release translated languages * add docs from qgis * update of qgis 3.22 version * Translate /app/i18n/input_en.ts in hr_HR translation completed for the source file '/app/i18n/input_en.ts' on the 'hr_HR' language. * remove unused highlightsgnode class * fix wrong rebase * === instad of == Co-authored-by: Tomas Mizera <tomas.mizera@lutraconsulting.co.uk> * update QtQuick version Co-authored-by: Tomas Mizera <tomas.mizera@lutraconsulting.co.uk> * address reviews * reduce navigation highlight complexity * fix c++ layout * CACHE_VERSION : 1 * fix extent and start point * remove closing the navigation when map is clicked * close navigation properly when drawer is closed * use different icon for recenter operation * remove debug prints * move the accuracy button above the panels when necessary * add some unit tests * fix c++ layout * try to fix build * disable follow GPS when in navigation * change CACHE_VERSION to 2 * fix 2, 3 & 5 * fix cpp layout * fix 7: recenter on close * invalidate qt cache * add cache to macos CI build * fix crash on multipoint layers - issue 4 * try fix test * add small border around navigation line - fixes 6 * show message when location is unavailable in navigation - 8 * add isPointLayerFeature test * fix accuracy button height offset * fix unresponsive map canvas after calling endNavigation * address Tomas comments Co-authored-by: PeterPetrik <zilolv@gmail.com> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> Co-authored-by: Tomas Mizera <tomas.mizera@lutraconsulting.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaces use of pixels in font sizes with points.
Video from my Android:
(DPR: 2.625)
MNML-December13-010028PM.mp4
@wonder-sk I think we will need to higher the font size in the entire application, however, could you please try to run on your device first and see if it helps with #1833 ?
Resolves #1833