8000 Added github button by madeleine-patience · Pull Request #239 · Melkeydev/astrostation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added github button #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 28, 2023
Merged

Added github button #239

merged 5 commits into from
Mar 28, 2023

Conversation

madeleine-patience
Copy link
Contributor

No description provided.

@vercel
Copy link
vercel bot commented Mar 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
astrostation ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 28, 2023 at 4:55AM (UTC)

@Melkeydev
Copy link
Owner

@madeleine-patience Can you make this commit against staging instead of GH?

  • add yourself to the contributors file too!

Melkeydev
Melkeydev reviewed Mar 22, 2023
View reviewed changes
Melkeydev
Melkeydev requested changes Mar 22, 2023
View reviewed changes
Copy link
Owner
@Melkeydev Melkeydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nits

@madeleine-patience madeleine-patience changed the base branch from main to staging March 23, 2023 01:42
royanger
royanger suggested changes Mar 23, 2023
View reviewed changes
@madeleine-patience
Copy link
Contributor Author

@madeleine-patience Can you make this commit against staging instead of GH?

  • add yourself to the contributors file too!

Both of these are done.

@Melkeydev
Copy link
Owner

image
The image seems to be a bit small.
the padding of the button is taking more of the attention than the actual GH logo.
Can we increase the size of the GH icon so it fills in more of the real-estate?

@madeleine-patience
Copy link
Contributor Author

Thank you for the comments, I've updated as you requested, PTAL

@madeleine-patience
Copy link
Contributor Author

I just had a second look this morning- maybe the buttons should be square.
8000

Hacksore
Hacksore reviewed Mar 26, 2023
View reviewed changes
@royanger
Copy link
Contributor

Hey @madeleine-patience, we noticed that the new component that holds the bottom buttons is missing some left padding. The Donate button is butting up against the edge of the screen. Compare that to the production release to see the difference.

@madeleine-patience
Copy link
Contributor Author

@royanger padding re-added and @Hacksore I changed the navigate function to an anchor tag instead.

@royanger royanger merged commit cc997e7 into Melkeydev:staging Mar 28, 2023
@royanger royanger mentioned this pull request Mar 28, 2023
Closed
mechakin pushed a commit to mechakin/astrostation that referenced this pull request Oct 16, 2023
@royanger
Merge pull request Melkeydev#239 from madeleine-patience/main
a467f75 
Added github button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hacksore Hacksore Hacksore left review comments

@royanger royanger royanger approved these changes

@Melkeydev Melkeydev Awaiting requested review from Melkeydev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@madeleine-patience @Melkeydev @royanger @Hacksore
0