fix: Armor will now show in its name if its Clan or IS, allowing for warehouse automation to work properly #6893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warehouse automation to work properly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6893 +/- ##
============================================
- Coverage 11.57% 11.57% -0.01%
- Complexity 6610 6611 +1
============================================
Files 1100 1100
Lines 141034 141071 +37
Branches 21846 21848 +2
============================================
- Hits 16329 16328 -1
- Misses 123004 123045 +41
+ Partials 1701 1698 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IllianiBird
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
Armor will now show in its name if its Clan or IS, allowing for warehouse automation to work properly. The armor pieces origin faction only matter for construction, and by extension they matter for repair and stock on MekHQ.
Before:
After:
This enables the parts in use report to show IS and Clan armor individually, however this also shows that we need to fix that in the Parts in use report itself, it needs to have the faction (IS/Clan) exposed and being used as part of a composed index.