Fix: Fixed Arrival Time in Several Scenario Templates #6814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Dev Notes This removes the arrival time delay for several scenarios. The addition of the arrival time deplay made sense of paper, less so in practice. I also removed an errant reinforcement force that didn't need to be in the scenario.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6814 +/- ##
=========================================
Coverage 11.45% 11.46%
- Complexity 6499 6504 +5
=========================================
Files 1098 1098
Lines 140854 140807 -47
Branches 21841 21829 -12
=========================================
+ Hits 16130 16138 +8
+ Misses 123050 122998 -52
+ Partials 1674 1671 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DM0000
approved these changes
Apr 29, 2025
|
Juat gone from skirmish |
Scoppio
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev Notes
This removes the arrival time delay for several scenarios. The addition of the arrival time deplay made sense of paper, less so in practice.
I also removed an errant reinforcement force that didn't need to be in the scenario.