8000 49.19.1 Every time I load my campaign one of my dropships has damaged thrusters. · Issue #4163 · MegaMek/mekhq · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

49.19.1 Every time I load my campaign one of my dropships has damaged thrusters. #4163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Daishi-5 opened this issue Jun 6, 2024 · 4 comments · Fixed by #5254
Closed

49.19.1 Every time I load my campaign one of my dropships has damaged thrusters. #4163

Daishi-5 opened this issue Jun 6, 2024 · 4 comments · Fixed by #5254
Labels
Bug

Comments

@Daishi-5
Copy link
Daishi-5 commented Jun 6, 2024

What version of MekHQ does your issue apply to?
49.19.1
What operating system are you using? Windows, Mac, or Linux?
Windows

What java version are you using? If unsure it will state your java version at the top of the mekhq.log file.
Java Vendor: Eclipse Adoptium
Java Version: 11.0.16.1

Short description:

Every time I load my campaign 1 dropship, name: "Union (2078)", has more damaged thrusters.

The behavior is really weird.

At first, I noticed that it had 8 damaged thrusters, 4 on each side. I repaired them all normally, thinking maybe it had been battle damage from a deployment.

Later I noticed 8 damaged thrusters again, and I repaired them again normally. At this time, I still hadn't figure out it was related to loading the save.

Then, I reloaded to fix deployed auxiliary units, and I noticed the 8 damaged thrusters again. This time I got screenshots to replicate the issue.

Here are the damaged thrusters, and then I used GM mode to fix all the replacement thrusters I had, leaving 3 damaged.
image
image

Then, I reloaded to see if the thrusters were damaged again, and now I have 12 damaged thrusters. (Note, in the screenshot, the unit card on the left says 4 left damaged, and 4 right damaged, but there are 12 thrusters available for repair in the center.)

image

Just to check, I saved it again with the 12 damaged thrusters, and reloaded, now I have 14 damaged thrusters. The unit card still says 8.

My Campaign30860517-4.cpnx.gz
My Campaign30860517-3.cpnx.gz
My Campaign30860517-2.cpnx.gz
customs.zip
@repligator
Copy link
Collaborator
repligator commented Jun 6, 2024 •
edited
Loading

The issue seems to persist under 2024-06-03T01:14:09.813417422 (Java 17.0.10, Linux). I don't see anything in the logs that would indicate an issue either.
On the bright side, using GM mode to restore the unit from the hanger screen seems to have made the issue disappear.

@repligator repligator added the Bug label Oct 3, 2024
@TenkawaBC
Copy link
Contributor
TenkawaBC commented Nov 24, 2024 •
edited
Loading

This may be related to bug #4849

Edit: On closer inspection, it is not the same cause.

@TenkawaBC
Copy link
Contributor

Checking my.campaign30860517-4.cpnxM i can see this.
<part id="224396" type="mekhq.campaign.parts.MissingThrusters"> <id>224396</id> <name>Thrusters</name> <unitTonnage>3600</unitTonnage> <mode>NORMAL</mode> <skillMin>1</skillMin> <unitId>1ec2f4a5-2387-4202-9bbd-0f62ba2dee40</unitId> <brandNew>false</brandNew> <quantity>1</quantity> <quality>3</quality> <isLeftThrusters>false</isLeftThrusters> </part>

Parts 224396 through 224699. I'm seeing 10 entries in the campaign file.

Unit ID matches the dropship for all of them
<unit id="1ec2f4a5-2387-4202-9bbd-0f62ba2dee40" type="mekhq.campaign.unit.Unit"> <entity chassis="Union" model="(2708)" type="Spheroid" commander="false" externalId="1ec2f4a5-2387-4202-9bbd-0f62ba2dee40" altitude="5">

TenkawaBC added a commit to TenkawaBC/mekhq that referenced this issue Nov 26, 2024
@TenkawaBC
Fixing bug MegaMek#4163. This allows the left thruster to be a missin…
79c9dcd 
…g part correctly.

It does not clear excess missing Thrusters, but they won't return.
@TenkawaBC
Copy link
Contributor

Submitted a pull request for a fix on this, #5254

The left thrusters were not getting created as missing parts correctly.

@HammerGS HammerGS mentioned this issue Nov 26, 2024
Merged
HammerGS added a commit that referenced this issue Nov 29, 2024
@HammerGS
Merge pull request #5254 from TenkawaBC/MekHQ4163
452081a 
Fixing bug #4163. This allows the left thruster to be a missing part
@github-project-automation github-project-automation bot moved this from Todo to Done in Bug Catcher: Dropships Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
Bug Catcher: Dropships
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing bug #4163. This allows the left thruster to be a missing part TenkawaBC/mekhq
3 participants
@TenkawaBC @repligator @Daishi-5
0