[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing random CI failures due to message skips #74

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from

Conversation

aryanjassal
Copy link
Contributor

Description

This PR focuses on resolving #70, which is a critical bug that happens in the CI because the second message is skipped.

Issues Fixed

Tasks

  • 1. Fix the error
  • 2. Run all tests to ensure the error isn't present
  • 3. Change the method from cancelling and attaching streams to instead be more dynamic like returning a promise for the header.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@aryanjassal aryanjassal self-assigned this Dec 2, 2024
Copy link
linear bot commented Dec 2, 2024

messages: specificMessageArb,
},
// { numRuns: 1 },
{ seed: 1292472631, path: "0", endOnFailure: true }
Copy link
Contributor Author
@aryanjassal aryanjassal Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this failing run from a previously failing action, but now, all the tests are passing without failures. This was also the case before, where all the tests passed during development in my branch, and locally too, but when I merged the branch, the tests began failing everywhere.

I tried to uncomment the tests and add a known failing case to replicate the issue so I can attempt to fix it, but I couldn't do that, as the tests are now all passing.

Action: https://github.com/MatrixAI/js-rpc/actions/runs/11733584104/job/32688941570#step:5:269

@tegefaulkes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might try modifying the CI file to run CI across all platforms like MacOS and Windows, just in case the issue is triggered via a run on MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Transferring data through the RPC stream skips the second message
1 participant