Unified client for Manta and Calamari #245
Conversation
|
Should our manta runtime be renamed from Manta/runtime/manta/src/lib.rs Line 104 in 2a8526d But if we change this name, I'm not sure whether we need to submit a pr to polkadot-js. BTW, what's the size of new client binary? |
|
Please rename that dockerfile, because we're going to unify the binary, there's no need to keep that name of dockerfile. |
I think we still need two docker file? since the genesis are different? |
Maybe we can get what suggestion from devops' perspective. |
Description
closes: #232
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
mantaormanta-pc) with right title (start with [Manta] or [Manta-PC]),Files changedin the Github PR explorer.authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated