8000 :rocket: update `public draft releases` trigger condition by anaye1997 · Pull Request #1281 · Manta-Network/Manta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

🚀 update public draft releases trigger condition #1281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 25, 2023
Merged

🚀 update public draft releases trigger condition #1281

merged 1 commit into from
Dec 25, 2023

Conversation

anaye1997
Copy link
Contributor
@anaye1997 anaye1997 commented Dec 25, 2023 •
edited
Loading

Signed-off-by: Anathan (Ana) Ye anaye@duck.com

Description

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@anaye1997
🚀 update public draft releases trigger condition
4cc49af 
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
@anaye1997 anaye1997 requested a review from a team as a code owner December 25, 2023 06:37
@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 25, 2023 •
edited
Loading

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above the target daily congestion cost

@github-actions GitHub Actions
Copy link
github-actions bot commented Dec 25, 2023 •
edited
Loading

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

@Dengjianping Dengjianping merged commit 7f0e407 into manta Dec 25, 2023
@Dengjianping Dengjianping deleted the feature/update-public-draft-release-trigger-condition-2 branch December 25, 2023 07:56
anaye1997 added a commit that referenced this pull request Dec 26, 2023
@anaye1997
🚀 update public draft releases trigger condition (#1281)
68669fa 
Signed-off-by: Anathan (Ana) Ye <anaye@duck.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dengjianping Dengjianping Dengjianping approved these changes

@ryanlin-tech ryanlin-tech ryanlin-tech approved these changes

Assignees
No one assigned
Labels
A-benchmark-checks A-congestion-test-checks A-integration-test-checks A-unit-test-checks L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anaye1997 @Dengjianping @ryanlin-tech
0