8000 fix(lottery): prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) by Garandor · Pull Request #1211 · Manta-Network/Manta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(lottery): prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 17, 2023
Merged

fix(lottery): prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) #1211

merged 12 commits into from
Jul 17, 2023

Conversation

Garandor
Copy link
Contributor
@Garandor Garandor commented Jul 13, 2023 •
edited
Loading

Signed-off-by: Adam Reif Garandor@manta.network

Description

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Adam Reif added 4 commits July 12, 2023 10:31
clarify sanity checks (no difference in behavior)
558117e 
Signed-off-by: Adam Reif <Garandor@manta.network>
fix: don't fail drawing if no collator is found for restaking
e333a06 
Signed-off-by: Adam Reif <Garandor@manta.network>
test: testcase similar to bug found on testnet, multiround_withdraw_p…
f4170a7 
…artial_deposit_works2. Passes

Signed-off-by: Adam Reif <Garandor@manta.network>
undo depending on surplus_funds in sanity check
96237c4 
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor force-pushed the jumboshrimps_fix1 branch from fdd9971 to 96237c4 Compare July 13, 2023 17:08
@Garandor Garandor added A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes labels Jul 13, 2023
@Garandor Garandor changed the title clarify sanity checks (no difference in behavior) Fix: Don't fail the drawing on restaking if all available collators are currently unstaking, clarify sanity checks (no difference in behavior) Jul 13, 2023
@Garandor Garandor added C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes and removed C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes labels Jul 13, 2023
@Garandor Garandor changed the title Fix: Don't fail the drawing on restaking if all available collators are currently unstaking, clarify sanity checks (no difference in behavior) fix(lottery): Don't fail the drawing on restaking if all available collators are currently unstaking, clarify sanity checks (no difference in behavior) Jul 13, 2023
@Garandor Garandor self-assigned this Jul 13, 2023
@github-actions
Copy link
github-actions bot commented Jul 13, 2023 •
edited
Loading

✅ Congestion test: 1-day congestion cost (manta-runtime) is above the target daily congestion cost

@github-actions
Copy link
github-actions bot commented Jul 13, 2023 •
edited
Loading

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above the target daily congestion cost

Adam Reif and others added 2 commits July 13, 2023 16:25
@Garandor Garandor linked an issue Jul 14, 2023 that may be closed by this pull request
Lottery: Drawing fails on multiround withdrawals when all available collators are being unstaked at the same time #1213
Closed
@Garandor Garandor changed the title fix(lottery): Don't fail the drawing on restaking if all available collators are currently unstaking, clarify sanity checks (no difference in behavior) fix(lottery): prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) Jul 14, 2023
Adam Reif added 2 commits July 13, 2023 23:22
fix: prevent deposits or collator assignments below min_deposit()
4152ae0 
Signed-off-by: Adam Reif <Garandor@manta.network>
clippy
54c52d1 
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor linked an issue Jul 14, 2023 that may be closed by this pull request
Lottery: Staking distribution can split a deposit into multiple subdeposits, each below min_deposit #1215
Closed
clippy
1e3900d 
Signed-off-by: Adam Reif <Garandor@manta.network>
ghzlatarev
ghzlatarev previously approved these changes Jul 14, 2023
View reviewed changes
fix: sanity check breaks restaking on drawing
d4e7c09 
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor changed the title fix(lottery): prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) fix(lottery): lottery restaking failures, prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) Jul 14, 2023
@Garandor Garandor changed the title fix(lottery): lottery restaking failures, prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) fix(lottery): prevent depositing below min_deposit, don't fail drawing on no available collators, clarify sanity checks (no difference in behavior) Jul 14, 2023
@github-actions
Copy link

Please signoff on all commits with your name, email and gpg key for the Developer's Certificate of Origin.
git config --global user.name your_name
git config --global user.email you_email
COMMAND : git commit -s -S -m your_commit_message
-s = Signed-off-by
-S = Verify commit using gpg key
If there is more than one commit in your pull request and your git client is modern enough (2.13+), rebase the required number of commits with --signoff:
git rebase --signoff HEAD~<number_of_commits>
Then, force push:
git push -f origin <your_branch>
For instructions on managing gpg signature verification please visit: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Revert "fix: sanity check breaks restaking on drawing"
6da18ca 
This reverts commit d4e7c09.

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor force-pushed the jumboshrimps_fix1 branch from f5eb24b to 6da18ca Compare July 14, 2023 05:47
@ghzlatarev ghzlatarev merged commit 852ef1d into manta Jul 17, 2023
@ghzlatarev ghzlatarev deleted the jumboshrimps_fix1 branch July 17, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Apokalip Apokalip Apokalip approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@Dengjianping Dengjianping Awaiting requested review from Dengjianping

@ferrell-code ferrell-code Awaiting requested review from ferrell-code

Assignees

@Garandor Garandor

Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-bug Category: Issues documenting a bug L-fixed Log: Issues and PRs related to bug fixes
Projects
None yet
Milestone
No milestone
3 participants
@Garandor @Apokalip @ghzlatarev
0