8000 manta-farming by zqhxuyuan · Pull Request #1141 · Manta-Network/Manta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

manta-farming #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 5, 2023
Merged

manta-farming #1141

merged 31 commits into from
Jul 5, 2023

Conversation

zqhxuyuan
Copy link
Contributor
@zqhxuyuan zqhxuyuan commented Jun 5, 2023

Description

farming protocol:

  • deposit: user deposit token into farming pool, and get share
  • withdraw: user remove share from farming pool
  • claim: user can get rewards when they stake token into farming pool
  • withdraw_claim: user can un-stake token from farming pool.

Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan zqhxuyuan added C-enhancement Category: An issue proposing an enhancement or a PR with one A-calamari Area: Issues and PRs related to the Calamari Runtime L-added Log: Issues and PRs related to addition labels Jun 5, 2023
@zqhxuyuan zqhxuyuan changed the title add farming manta-farming Jun 5, 2023
zqhxuyuan added 3 commits June 5, 2023 15:12
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@github-actions
Copy link
github-actions bot commented Jun 5, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
zqhxuyuan added 2 commits June 9, 2023 16:37
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Copy link
Contributor
@ghzlatarev ghzlatarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is there an e2e test for QA-ing this ?

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@github-actions
Copy link
github-actions bot commented Jun 27, 2023

⚠️ Congestion test: 1-day congestion cost (calamari-runtime) is NOT above target_daily_congestion_cost_kma

@github-actions
Copy link
github-actions bot commented Jun 27, 2023

⚠️ Congestion test: 1-day congestion cost (manta-runtime) is NOT above target_daily_congestion_cost_kma

Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
zqhxuyuan added 2 commits July 3, 2023 19:40
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
zqhxuyuan added 2 commits July 3, 2023 20:19
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
ghzlatarev
ghzlatarev previously approved these changes Jul 3, 2023
@ghzlatarev ghzlatarev added the A-manta Area: Issues and PRs related to the Manta Runtime label Jul 3, 2023
@ghzlatarev ghzlatarev requested a review from Dengjianping July 3, 2023 17:22
@ghzlatarev
Copy link
Contributor

Btw can you add a description with the major beats and why they are so

zqhxuyuan added 2 commits July 4, 2023 22:39
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ghzlatarev ghzlatarev merged commit 429109e into manta Jul 5, 2023
@ghzlatarev ghzlatarev deleted the farming branch July 5, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-manta Area: Issues and PRs related to the Manta Runtime C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0