8000 Update xcm-onboarding and release templates by ghzlatarev · Pull Request #715 · Manta-Network/Manta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update xcm-onboarding and release templates #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 28, 2022
Merged

Update xcm-onboarding and release templates #715

merged 14 commits into from
Jul 28, 2022

Conversation

ghzlatarev
Copy link
Contributor
@ghzlatarev ghzlatarev commented Jul 26, 2022 •
edited
Loading

Description

closes: #600

  • Update release update to mention Calamari @ Moonbase-Relay as well as Dolphin @ Baikal internal testnets. Dolphin @ Rococo should not be part of the testing process, because this is a user-facing (semi-production) environment that we don't want to screw up accidentally without having it tested.
  • Update the xcm onboarding template to include the process for the production chains to make it clearer. Also add an instruction for opening governance proposals on Calamari.

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

@ghzlatarev
Update release changelog with Moonbase-relay
8778285 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update xcm onboarding template
48951fe 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Add example gov proposal
d3ebf7b 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update xcm onboarding template
d84fa56 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Use Dolphin @ Baikal instead of Rococo
71ae5ea 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
COrrections
7bbbd69 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Jul 26, 2022
@ghzlatarev ghzlatarev added A-documentation Area: Improvements or additions to documentation C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes labels Jul 26, 2022
@ghzlatarev
Add grafana node explorer checks to process
a3e6846 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Remove como mention
1cf7dca 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Garandor
Garandor reviewed Jul 26, 2022
View reviewed changes
Garandor
Garandor reviewed Jul 26, 2022
View reviewed changes
Garandor
Garandor reviewed Jul 26, 2022
View reviewed changes
Garandor
Garandor reviewed Jul 26, 2022
View reviewed changes
@ghzlatarev
Review suggestions
bfee0fd 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Dedupe
681a1e7 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
More detailed example of what to look for
3c92ea1 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev requested a review from Garandor July 27, 2022 09:02
@ghzlatarev
Mention status manta network
ba4e9b8 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@Dengjianping Dengjianping mentioned this pull request Jul 28, 2022
Merged
3 tasks
@ghzlatarev ghzlatarev merged commit 2f68b2e into manta Jul 28, 2022
@ghzlatarev ghzlatarev deleted the ghzlatarev/update-release-template branch July 28, 2022 06:37
@Garandor
Copy link
Contributor
Garandor commented Jul 28, 2022 •
edited
Loading

@ghzlatarev pls don't close tracking issues, at least for those, use relates to.

Unless we can agree that closes #xyz against an already closed PR is valid, then we can just leave all tracking issues closed and link PRs against the closed ones using closes.

this close -> reopen -> close cycle is something i want to avoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stechu stechu stechu approved these changes

@Garandor Garandor Garandor approved these changes

@Dengjianping Dengjianping Awaiting requested review from Dengjianping

@Apokalip Apokalip Awaiting requested review from Apokalip

@flame4 flame4 Awaiting requested review from flame4

Assignees

@ghzlatarev ghzlatarev

Labels
A-documentation Area: Improvements or additions to documentation C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking: Improve documentation
3 participants
@ghzlatarev @Garandor @stechu
0