8000 Use `LengthToFee` in the `congested_chain_simulation`'s fee calculation by ghzlatarev · Pull Request #682 · Manta-Network/Manta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use LengthToFee in the congested_chain_simulation's fee calculation #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 26, 2022
Merged

Use LengthToFee in the congested_chain_simulation's fee calculation #682

merged 14 commits into from
Jul 26, 2022

Conversation

ghzlatarev
Copy link
Contributor
@ghzlatarev ghzlatarev commented Jul 14, 2022 •
edited
Loading

Signed-off-by: Georgi Zlatarev georgi.zlatarev@manta.network

Description

closes: #530

  • In 0.9.22 update pallet_transaction_payment started using LengthToFee to scale its fee component that is generated from the transaction byte length.
  • Started using this in our congested_chain_simulation fee calculation as well.
  • No functional changes

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functonality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics

@ghzlatarev
Use lentofee in congested_chain_simulation test calculation
2ff2bf2 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev self-assigned this Jul 14, 2022
@ghzlatarev ghzlatarev added the A-testing Area: Testing-related Issues and PRs label Jul 14, 2022
@ghzlatarev ghzlatarev marked this pull request as ready for review July 14, 2022 12:12
@ghzlatarev
Changelog
583388d 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev ghzlatarev changed the title Use WeightToFeePolynomials in the congested_chain_simulation's fee calculation Use LengthToFee in the congested_chain_simulation's fee calculation Jul 14, 2022
@ghzlatarev
Changelog update
1884c5e 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Changelog update
2a8eb09 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Garandor
Garandor previously approved these changes Jul 16, 2022
View reviewed changes
Copy link
Contributor
@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dengjianping
Dengjianping reviewed Jul 19, 2022
View reviewed changes
@ghzlatarev
Formatting
978643d 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Fix merge conflict in CHANGELOG.md
f6913f1 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update CHANGELOG with Unreleased section
3260d65 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Update CHANGELOG with Unreleased section
e50bde0 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Fix changelog
6223dbe 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
Dengjianping
Dengjianping previously approved these changes Jul 20, 2022
View reviewed changes
Garandor
Garandor suggested changes Jul 20, 2022
View reviewed changes
@ghzlatarev
Fix old changelog
a8ccde6 
Signed-off-by: Georgi Zlatarev <georgi.zlatarev@manta.network>
@ghzlatarev
Merge branch 'manta' into ghzlatarev/lentofee-final
693c9bd
@Garandor
Copy link
Contributor

relates to OR closes: #530

pick one

@ghzlatarev
Copy link
Contributor Author

relates to OR closes: #530

pick one

Not sure if I'm not getting something, but it always has to be closes in order for the PR ot show up linked to the issue in the github project board...

@Garandor
Copy link
Contributor

relates to OR closes: #530
pick one

Not sure if I'm not getting something, but it always has to be closes in order for the PR ot show up linked to the issue in the github project board...

It doesn't have to show up in the project board. it's fine to click 8000 into the issue and to the PR from there.
If it relates to, the issue should mention the PR in its description ( and it will show open/closed status as well )
That way there's no reopening of issues that have multiple PRs

@ghzlatarev
Copy link
Contributor Author
ghzlatarev commented Jul 20, 2022 •
edited
Loading

relates to OR closes: #530

pick one

Not sure if I'm not getting something, but it always has to be closes in order for the PR ot show up linked to the issue in the github project board...

It doesn't have to show up in the project board. it's fine to click into the issue and to the PR from there.

If it relates to, the issue should mention the PR in its description ( and it will show open/closed status as well )

That way there's no reopening of issues that have multiple PRs

Yea I know you can click on the issue, but when there are many issues it's more convenient to see them on board. That's why we had chosen the other inconvenience of having to reopen issues sometimes over this..

EDIT: actually aren't we trying to solve is the manual work of reopening issues, which we're replacing with the manual work of going back to the issue and editing its description ? Not sure we're gaining anything for the loss of the nice board view with everything plus history.

Dengjianping
Dengjianping reviewed Jul 25, 2022
View reviewed changes
@ghzlatarev ghzlatarev requested a review from Dengjianping July 25, 2022 14:26
@Garandor Garandor self-requested a review July 25, 2022 18:04
Garandor
Garandor previously requested changes Jul 25, 2022
View reviewed changes
Copy link
Contributor
@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add C- and L- labels

@ghzlatarev ghzlatarev added C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes labels Jul 25, 2022
@ghzlatarev ghzlatarev requested a review from Garandor July 25, 2022 18:07
Dengjianping
Dengjianping approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor
@Dengjianping Dengjianping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ghzlatarev ghzlatarev merged commit 9699976 into manta Jul 26, 2022
@ghzlatarev ghzlatarev deleted the ghzlatarev/lentofee-final branch July 26, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stechu stechu stechu approved these changes

@Dengjianping Dengjianping Dengjianping approved these changes

@Apokalip Apokalip Awaiting requested review from Apokalip

@flame4 flame4 Awaiting requested review from flame4

@Garandor Garandor Awaiting requested review from Garandor

Assignees

@ghzlatarev ghzlatarev

Labels
A-testing Area: Testing-related Issues and PRs C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust congested_chain_simulation test when we integrate account for the length component of the transaction fee
4 participants
@ghzlatarev @Garandor @stechu @Dengjianping
0