Fix AssetManager's update_asset_metadata #461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
AssetManager's update_asset_metadata
AssetManager's update_asset_metadata|
If you look at https://github.com/Manta-Network/Manta/blob/manta/runtime/primitives/src/assets.rs#L30 /// The metadata of a Manta Asset
#[derive(Clone, Default, Eq, Debug, PartialEq, Ord, PartialOrd, Encode, Decode, TypeInfo)]
pub struct AssetRegistarMetadata<Balance> {
pub name: Vec<u8>,
pub symbol: Vec<u8>,
pub decimals: u8,
pub evm_address: Option<H160>,
pub is_frozen: bool,
pub min_balance: Balance,
/// `is_sufficient`: Whether a non-zero balance of this asset is deposit of sufficient
/// value to account for the state bloat associated with its balance storage. If set to
/// `true`, then non-zero balances may be stored without a `consumer` reference (and thus
/// an ED in the Balances pallet or whatever else is used to control user-account state
/// growth).
/// For example, if is_sufficient set to `false`, a fresh account cannot receive XCM tokens.
pub is_sufficient: bool,
}This is more than what |
stechu
requested changes
Mar 27, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
stechu
reviewed
Apr 9, 2022
stechu
requested changes
Apr 9, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
…ault Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
…manager in Dolphin Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
stechu
approved these changes
Apr 10, 2022
Signed-off-by: ghzlatarev <ghzlatarev@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ghzlatarev ghzlatarev@gmail.com
Description
closes: #462
AssetManager'supdate_asset_metadatawas not actually updating the underlyingAssetsdata, so now the extrinsic is calling theT::AssetRegistrar::update_asset_metadatain order to do so.NextAssetIdstorage should be set toStartNonNativeAssetIdinstead ofNativeAssetIdon genesis. Fix benchmarking, add asset-manager to benchmarking workflow.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.mdFiles changedin the Github PR explorer.authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updatedBaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime. This includes migrations inhreited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]items to check for any.