10000 [manta]3141 release by Dengjianping · Pull Request #407 · Manta-Network/Manta · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[manta]3141 release #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2022
Merged

[manta]3141 release #407

merged 3 commits into from
Feb 20, 2022

Conversation

Dengjianping
Copy link
Contributor
@Dengjianping Dengjianping commented Feb 18, 2022 •
edited
Loading

Description

This pr is a hotfix for the issue about some low hanging fruit in democracy pallet.
19162e43be45817b44c7d48e50d03f074f60fbf4 => 19162e43be45817b44c7d48e50d03f074f60fbf4

Related pr: paritytech/substrate#10867

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (manta or dolphin) with right title (start with [Manta] or [Dolphin]),
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. If this number is updated, then the spec_version must also be updated
  • If needed, notify the committer this is a draft-release and a tag is needed after merging the PR.
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If needed, bump version for every crate.
  • If import a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are offcially used by exchanges or community developers.
  • If we're going to issue a new release, freeze the code one week early(it depends, but usually it's one week), ensure we have enough time for related testing.
  • Check if inheriting any upstream runtime storage migrations. If any, perform tests with try-runtime.

@Dengjianping Dengjianping requested review from codecarrier1, dziabko, Garandor, ghzlatarev and stechu and removed request for codecarrier1 February 18, 2022 15:53
@Dengjianping Dengjianping self-assigned this Feb 18, 2022
@Dengjianping Dengjianping added this to the v3.1.5 milestone Feb 18, 2022
@Dengjianping Dengjianping changed the title [manta]Bump substrate [manta]3141 release Feb 18, 2022
@Dengjianping Dengjianping removed this from the v3.1.5 milestone Feb 18, 2022
@Garandor
Copy link
Contributor

One comment: It's a bit weird that the changelog contains an added
[\#403](https://github.com/Manta-Network/Manta/pull/403) Remove pallet_scheduler v3 migration after 3140 runtime upgrade.
when this is not actually part of this PR.

I would propose that a PR that wants to merge to Manta should also contain a line in Changelog.md so the commit a change was introduced can be easily found by git blame-ing the Changelog.

It should be under a new #Unreleased section header and the release PR just renames this header to the release version

@stechu stechu merged commit b5133a5 into manta Feb 20, 2022
@Garandor Garandor mentioned this pull request Feb 23, 2022
Merged
dziabko pushed a commit that referenced this pull request Mar 8, 2022
@Dengjianping @dziabko
[manta]3141 release (#407)
ab2fc7e 
* Bump substrate

* Bump spec version and update changelog
@ghzlatarev ghzlatarev deleted the jamie/bump-substrate branch March 9, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garandor Garandor Garandor approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@dziabko dziabko Awaiting requested review from dziabko

@stechu stechu Awaiting requested review from stechu

Assignees

@Dengjianping Dengjianping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Dengjianping @Garandor @ghzlatarev @stechu
0