Implemented redux state management #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync-up PR (Jun Han)
Sync-up PR (Jun Han)
Prakhar896
requested changes
Jul 5, 2024
|
|
||
| function Navbar() { | ||
| const { isOpen, onOpen, onClose } = useDisclosure() | ||
| const navigate = useNavigate(); | ||
|
|
||
| const handleAvatarClick = () => { |
There was a problem hiding this comment.
I have made the changes to Sidebar.jsx also.
src/slices/AuthState.js
Outdated
| dispatch(setLoading(false)); | ||
| try { | ||
| const response = await server.get('/cdn/MyAccount', { |
There was a problem hiding this comment.
Consider changing endpoint to camel case.
There was a problem hiding this comment.
I've changed this one on frontend, do i need to go main branch to change for backend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched from using UserContext to authReducer.
Upon successful creation of JWTs,
authStateDatawill store theuserID,usernameanduserType.