authState, pivoting from localStorage to state, multiple bug fixes and slight UI improvement #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync-up PR (Joshua)
…nt data to reduce addresses to a approximate addess
…State flow. Updated useLocation state to just hostID, as userID is no longer needed after authState
… viewing their own listing
…useEffect in AuthLayout and Layout, and added navigate back to homepage if state was not found. Also fixed bug where rendering contents on homepage were jerky and glitchy
Prakhar896
requested changes
Jul 15, 2024
… useEffect dependancy array
…r user before rendering content, removing the need for the ternary condition
…at coordinates are only generated once per listing now, instead of once per listing on every page load
Prakhar896
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Quite well-done. Just do one last check for consistency and workflow. Test different variations of penetration angles of vulnerability, especially when it comes to the host's address. Ensure some invalid addresses do not crash the rendering workflow for remaining valid addresses.
expandedgooglemap
…joshua merging local and remote paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done in this PR
1.) Completed authState integration
2.) Switched from using localStorage to directly passing down a
statewhen navigating to/targetListing3.) Fixed multiple bugs (mostly related to authState integration)
4.) Removed hardcoded data
5.) Slightly improved UI
6.) Enhanced conditional rendering
7.) Added re-routing to
/*'s 404 page if user accidentally hits the/targetListingroute manually by accident without data passed down from state8.) Non logged-in users can now view the
GoogleMapsPage, but will need to login in order to favourite the listing.9.) Implmented a new
displayToastfactorised function due to unstableshowToastfunction inFoodListingand Homepage components/pagesSensitive changes
1.) Replaced the
useEffectcode in bothAuthLayout.jsxandLayout.jsxwith the new one @Prakhar896 providedPossible suggestions
1.) Restrict Navbar
minWidthto371px. Widths < 371px are too narrow2.) Add a
backbutton inReservationspage, so user doesn't have an impression that they are stuck at theReservationspage. Abackbutton is a clearer CTA than theSidebar