10000 Like Button State Managing & Rendering, Dynamic Data Fetching by lincoln0623 · Pull Request #40 · MakanMatch/Frontend · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Like Button State Managing & Rendering, Dynamic Data Fetching #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 49 commits into from
Jul 11, 2024
Merged

Like Button State Managing & Rendering, Dynamic Data Fetching #40

merged 49 commits into from
Jul 11, 2024

Conversation

lincoln0623
Copy link
Contributor

Overview of Changes Made

  • Like button UI for like and liked state
  • Like state is sustained upon upon refreshing for display what review is liked before by the user
  • Updated hostID and guestID from static ID to dynamic which fetches from the url parameters
    • TO DIRECT TO REVIEW PAGE:
    • E.g. reviews?hostID=272d3d17-fa63-49c4-b1ef-1a3b7fe63cf4&guestID=47f4497b-1331-4b8a-97a4-095a79a1fd48
  • Able to expand guest and host profile picture ( static src link )
  • Set minimum star rating to 1 star for both food and hygiene rating
  • Implemented showToast for toast rendering

Prakhar896 and others added 24 commits June 29, 2024 23:46
@Prakhar896
Merge pull request #27 from MakanMatch/main
3884115 
Sync-up PR (Lincoln)
@lincoln0623
Merge pull request #35 from MakanMatch/main
7b7d0e5 
Sync-up PR (Lincoln)
@lincoln0623
Fixed image display issue when there is no comment input
7490518
@lincoln0623
Fixed repetition issue
d4930cd
@lincoln0623
Fixed responsiveness and padding for reviews images layout
9342cb2
@lincoln0623
Changed React.Fragment to Box
f40dfe8
@lincoln0623
Remove displaying of error message, implemented showToast, removed un…
28606de 
…used state definition
@lincoln0623
Rename files
2888eaa
@lincoln0623
Correct routes for backend communication
1391a33
@lincoln0623
Fetch host id from url query
6328b75
@lincoln0623
change endpoint for liking review
5c6615f
@lincoln0623
90% done on like button component instead of refresh page like ui issue
bcf97a7
@lincoln0623
Image Expand Feature
4cd0f5e
@lincoln0623
Sustain liked status upon refreshing page after liking a review
039ce54
@lincoln0623
Added padding
f6f2092
@lincoln0623
Added tooltip for hygiene grade
970591b
@lincoln0623
make hostid and guestid dynamic and will redirect user back to homepa…
f9f628c 
…ge if userid not found
@lincoln0623
Remove star rating upon clicking it twice if the index are the same
8194bfc
@lincoln0623
Set comments if needed to future developed to accepting minimum 1 sta…
b4c3f95 
…r rating for both food and hygiene rating
@lincoln0623
Changed to 1 star minimum for food and hygiene rating
513ed5c
@lincoln0623
Change image sizes
7750aab
@lincoln0623
Removed redundant toast pop-up
b1f2e1d
@lincoln0623
Removed phone number rendering
42e328a
@lincoln0623
Expand user profile image in the review card
8a7a35c
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 8, 2024 08:45
@lincoln0623 lincoln0623 self-assigned this Jul 8, 2024
@Prakhar896 Prakhar896 added the enhancement New feature or request label Jul 8, 2024
Prakhar896
Prakhar896 requested changes Jul 8, 2024
View reviewed changes
Copy link
Contributor
@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disappointed in how you are writing your frontend code. For each refresh on root Reviews.jsx there is an exponentially increasing number of requests to fetch redundant and similar data. Data flow and sharing across sub-components isn't uniform also. This review demands a better and more uniform data flow. Each request to the backend is costly, use wisely.

lincoln0623 added 15 commits July 9, 2024 00:53
@lincoln0623
Remove redundant array type checking for reviews array, handle non-20…
513b6e5 
…0 status code response
@lincoln0623
Fixed width and layout issue
5922680
@lincoln0623
Changed like icon
0b52322
@lincoln0623
redesigned like button color
ba30159
@lincoln0623
make like button responsive
744602c
@lincoln0623
Changed route path at joshua's listing page and review page to make i…
4bb6c08 
…t more neater and readable
@lincoln0623
Removed unused imports and state definition
ffb7816
@lincoln0623
Removed redundant request for fetching reviewposter username while it…
79ca771 
… is included in the getReview fetching endpoint
@lincoln0623
Remove redundant fetching request
f67dc96
@lincoln0623
Removed unnecesasry refetching of like status as it is fetched in Sor…
e6cf8c7 
…tReviews.jsx
@lincoln0623
Removed unused imports and state definition
63c96a7
@lincoln0623
Optimized and simplify toggle like function
b0f1617
@lincoln0623
Changed static host id to dynamic by fetching it from FoodListingPage…
07b85b7 
….jsx
@lincoln0623
Added returns for error fetching to stop executing code after catches…
81b134f 
… an error
@lincoln0623
set minimum state of food and hygeiene rating to 1
7b22aa5
@lincoln0623 lincoln0623 requested a review from Prakhar896 July 11, 2024 05:10
Prakhar896
Prakhar896 requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor
@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-written; minor changes needed.

@lincoln0623 lincoln0623 requested a review from Prakhar896 July 11, 2024 08:39
Prakhar896
Prakhar896 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor
@Prakhar896 Prakhar896 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Prakhar896 Prakhar896 merged commit 13b496b into main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prakhar896 Prakhar896 Prakhar896 approved these changes

Assignees

@lincoln0623 lincoln0623

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lincoln0623 @Prakhar896
0