feat: add configurable agent namespaces #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the agent:chat command to find agent classes on namespaces specified in the config.
MaestroError
requested changes
May 16, 2025
src/Commands/AgentChatCommand.php
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| use Illuminate\Console\Command; | |||
| use Illuminate\Support\Str; | |||
| use LarAgent\Tests\Fakes\FakeLlmDriver; | |||
There was a problem hiding this comment.
Thanks @johalternate for your PR! All looks good 💪 Only this line seems like an extra, please remove it and I will merge the PR 👍
Comment on lines
+18
to
+21
| 'namespaces' => [ | ||
| 'App\\AiAgents\\', | ||
| 'App\\Agents\\', | ||
| ], |
There was a problem hiding this comment.
Can we also add a comment for this config to make sure everyone understands what is it for? Later, I will make sure to pick the first one from here while creating a new agent with command
There was a problem hiding this comment.
You got it. I will get on it later today.
MaestroError
approved these changes
May 16, 2025
There was a problem hiding this comment.
Thank you @johalternate for this PR! 🙏 If you already joined the LarAgent discord community, ping me there, I will give you a contributor role! 💪
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the agent:chat command to find agent classes on namespaces specified in the config.